From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 20 Mar 2020 13:31:13 -0400 Subject: [PATCH] mach-snapdragon: Fix overwriting last digit of serial number In-Reply-To: References: Message-ID: <20200320173113.GC5793@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Mar 16, 2020 at 05:51:51PM +0100, Jan-Christoph Tebbe wrote: > When generating the MAC address based on the boards serial number > the last digit was overwritten with the null termination. That way > boards with serial numbers close to each other would use the same > MAC address. > > Signed-off-by: Jan-Christoph Tebbe > --- > arch/arm/mach-snapdragon/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-snapdragon/misc.c b/arch/arm/mach-snapdragon/misc.c > index f6c87866c0..aaa561c2c6 100644 > --- a/arch/arm/mach-snapdragon/misc.c > +++ b/arch/arm/mach-snapdragon/misc.c > @@ -41,7 +41,7 @@ void msm_generate_mac_addr(u8 *mac) > int i; > char sn[9]; > > - snprintf(sn, 8, "%08x", msm_board_serial()); > + snprintf(sn, 9, "%08x", msm_board_serial()); > > /* fill in the mac with serialno, use locally adminstrated pool */ > mac[0] = 0x02; OK, so sn is size 9 and now you're filling the whole thing. Why don't we need to increase sn to size 10? Am I missing something? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: