From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"
Date: Mon, 23 Mar 2020 13:41:35 +0100 [thread overview]
Message-ID: <20200323134135.3341635c@jawa> (raw)
In-Reply-To: <357a2fb1-44e5-100a-63c9-1a9e6a1fd21a@denx.de>
Hi Marek,
> On 3/23/20 7:57 AM, Lukasz Majewski wrote:
> > Hi Marek,
>
> Hi,
>
> >> On 3/22/20 2:00 PM, Lukasz Majewski wrote:
> >>> This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6.
> >>>
> >>> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> >>
> >> This patch lacks any and all explanation why this is being
> >> reverted. The patch you are reverting here explains why it was
> >> added and what real issues it was fixing, so instead of reverting
> >> it, if there is an issue with that patch, you should identify the
> >> issue and fix it.
> >
> > Marek, have you received the cover letter for this patch series?
> >
> > In the cover letter I've written the rationale for reverting this
> > patch.
>
> That should have been explained in this patch description.
>
> > In short - qhtoken has value of 0x0, when the token variable shows
> > errors. As a result the error handling is broken.
> > Could you comment on those arguments?
>
> Maybe you are referencing/reading the wrong token ?
I'm printing the token which is used afterwards for reacting on possible
errors.
>
> You should probably figure out why this doesn't work first and then
> add fixes on top.
Haven't you seen such problem during code development on your setup
when developing this patch?
>
> > Moreover, I've explicitly stated that this is a Request For
> > Testing like patch series with a detailed report of testing
> > procedure (for my use case) for the USB in U-Boot (as Tom has
> > tested the patch with some ETH dongles).
>
> I was still unable to replicate the ethernet device failure.
>
Which boards and SoCs do you used for your test setup?
For me the issue is visible on i.MX53 and i.MX6Q.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200323/3a45d9e7/attachment.sig>
next prev parent reply other threads:[~2020-03-23 12:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 13:00 [RFT PATCH v1 0/5] usb: Improve robustness of ehci-hcd controller operation Lukasz Majewski
2020-03-22 13:00 ` [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running" Lukasz Majewski
2020-03-22 13:18 ` Marek Vasut
2020-03-23 6:57 ` Lukasz Majewski
2020-03-23 11:46 ` Marek Vasut
2020-03-23 12:41 ` Lukasz Majewski [this message]
2020-03-24 0:58 ` Marek Vasut
2020-03-24 7:06 ` Lukasz Majewski
2020-03-24 15:07 ` Marek Vasut
2020-03-24 18:11 ` Lukasz Majewski
2020-03-24 18:33 ` Marek Vasut
2020-03-22 13:00 ` [RFT PATCH v1 2/5] usb: Handle XACTERR error in DATA phase of USB storage Lukasz Majewski
2020-03-22 13:23 ` Marek Vasut
2020-03-23 7:00 ` Lukasz Majewski
2020-03-23 11:50 ` Marek Vasut
2020-03-23 13:03 ` Lukasz Majewski
2020-03-24 1:01 ` Marek Vasut
2020-03-22 13:00 ` [RFT PATCH v1 3/5] usb: Add some delay to wait for slow USB devices to be operational Lukasz Majewski
2020-03-22 13:29 ` Marek Vasut
2020-03-23 7:04 ` Lukasz Majewski
2020-03-23 11:52 ` Marek Vasut
2020-03-22 13:00 ` [RFT PATCH v1 4/5] usb: Provide code to handle spinup of USB usb devices (mostly HDDs) Lukasz Majewski
2020-03-22 13:32 ` Marek Vasut
2020-03-23 7:53 ` Lukasz Majewski
2020-03-23 11:57 ` Marek Vasut
2020-03-23 12:54 ` Lukasz Majewski
2020-03-24 1:04 ` Marek Vasut
2020-03-22 13:00 ` [RFT PATCH v1 5/5] usb: Handle QT_TOKEN_STATUS_XACTERR error when sending data Lukasz Majewski
2020-03-22 13:45 ` Marek Vasut
2020-03-23 7:18 ` Lukasz Majewski
2020-03-23 11:59 ` Marek Vasut
2020-03-23 12:58 ` Lukasz Majewski
2020-03-24 1:06 ` Marek Vasut
2020-03-23 20:58 ` [RFT PATCH v1 0/5] usb: Improve robustness of ehci-hcd controller operation Tom Rini
2020-03-23 22:11 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323134135.3341635c@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox