From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 23 Mar 2020 13:41:35 +0100 Subject: [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running" In-Reply-To: <357a2fb1-44e5-100a-63c9-1a9e6a1fd21a@denx.de> References: <20200322130031.10455-1-lukma@denx.de> <20200322130031.10455-2-lukma@denx.de> <7232a38a-3c6a-e397-21fc-5e2bff55f578@denx.de> <20200323075749.7c845b24@jawa> <357a2fb1-44e5-100a-63c9-1a9e6a1fd21a@denx.de> Message-ID: <20200323134135.3341635c@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, > On 3/23/20 7:57 AM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >>> This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6. > >>> > >>> Signed-off-by: Lukasz Majewski > >> > >> This patch lacks any and all explanation why this is being > >> reverted. The patch you are reverting here explains why it was > >> added and what real issues it was fixing, so instead of reverting > >> it, if there is an issue with that patch, you should identify the > >> issue and fix it. > > > > Marek, have you received the cover letter for this patch series? > > > > In the cover letter I've written the rationale for reverting this > > patch. > > That should have been explained in this patch description. > > > In short - qhtoken has value of 0x0, when the token variable shows > > errors. As a result the error handling is broken. > > Could you comment on those arguments? > > Maybe you are referencing/reading the wrong token ? I'm printing the token which is used afterwards for reacting on possible errors. > > You should probably figure out why this doesn't work first and then > add fixes on top. Haven't you seen such problem during code development on your setup when developing this patch? > > > Moreover, I've explicitly stated that this is a Request For > > Testing like patch series with a detailed report of testing > > procedure (for my use case) for the USB in U-Boot (as Tom has > > tested the patch with some ETH dongles). > > I was still unable to replicate the ethernet device failure. > Which boards and SoCs do you used for your test setup? For me the issue is visible on i.MX53 and i.MX6Q. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: