From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Behun <marek.behun@nic.cz>
Date: Wed, 25 Mar 2020 08:58:53 +0100
Subject: [PATCH 2/2] uboot: fs/btrfs: Fix LZO false decompression error
 caused by pending zero
In-Reply-To: <0e17f85f-46ab-2c2b-1547-3ef6b8b81d93@gmx.com>
References: <20200319123006.37578-1-wqu@suse.com>
 <20200319123006.37578-3-wqu@suse.com>
 <49c5af50-8c09-9b49-ab44-ebe5eb9a652c@gmail.com>
 <20200319135641.GB12659@twin.jikos.cz>
 <46e58bc7-4a4c-fa2a-33cd-0e8df65d6bac@suse.com>
 <20200319162822.GG12659@twin.jikos.cz>
 <0e17f85f-46ab-2c2b-1547-3ef6b8b81d93@gmx.com>
Message-ID: <20200325085853.618551ca@nic.cz>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, 24 Mar 2020 19:03:30 +0800
Qu Wenruo <quwenruo.btrfs@gmx.com> wrote:

> Sorry for the delayed reply. (Stupid filter setup).
> 
> Currently most Uboot boards should use the same page size setup for its
> kernel, and most btrfs uses 4K sector size.
> 
> So for Uboot it should be no problem.
> 
> Although the best practice is to read the fs_info::sectorsize as David
> mentioned, but the code base doesn't allow us to do that yet.
> 
> So I'm going to backport the read part code from btrfs-progs in the
> near-future, and completely solve it, making it sector size independent.
> 
> Would this plan looks sound? Or we need to wait for the full
> re-implementation?
> 
> Thanks,
> Qu
> 

The situation is Linux is such that btrfs sectorsize must be same as
PAGE_SIZE, otherwise the Linux btrfs driver won't work. AFAIK there are
only few architectures where PAGE_SIZE is not 4 KiB. btrfs filesystems
created there cannot be mounted on systems with PAGE_SIZE = 4 KiB.

I don't know if U-Boot is used on non 4KiB PAGE_SIZE boards. If it is,
it should be solved, but I would check that before complicating the
code.