From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] Revert "common: spl_fit: Default to IH_OS_U_BOOT if FIT_IMAGE_TINY enabled"
Date: Tue, 31 Mar 2020 08:01:24 -0400 [thread overview]
Message-ID: <20200331120124.GT27133@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5Abo2S1aYYnvwoXFAf61jqJxo6qLDAn4_1T0f8+kemcgA@mail.gmail.com>
On Tue, Mar 31, 2020 at 06:40:28AM -0300, Fabio Estevam wrote:
> Hi Ye Li,
>
> On Tue, Mar 31, 2020 at 6:00 AM Ye Li <ye.li@nxp.com> wrote:
> >
> > The patch in commit cf8dcc5d02c32173b74bf1b7600dd2b990a90b13 is not correct,
>
> 1. "Patch in commit" is not correct. Please refer it to "commit" instead.
>
> 2. Please use the same kernel style to refer to commit: 12 SHA digit
> and the subject between (" xxx ")
>
> So this would become:
>
> Commit cf8dcc5d02c3 ("common: spl_fit: Default to IH_OS_U_BOOT if
> FIT_IMAGE_TINY enabled") is not correct...
>
> > it will append fdt to each loadable image.
> > Actually when using TINY FIT, the first loadable image is thought as u-boot
> > and already have fdt appended.
> >
> > Signed-off-by: Ye Li <ye.li@nxp.com>
>
> Tested on a imx6q and imx6qp sabresd:
>
> Tested-by: Fabio Estevam <festevam@gmail.com>
You should also mention that you're reverting the previous commit and I
would really like Abel to confirm the problem they saw isn't
reproducible. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200331/a535c48b/attachment.sig>
next prev parent reply other threads:[~2020-03-31 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 8:59 [PATCH] Revert "common: spl_fit: Default to IH_OS_U_BOOT if FIT_IMAGE_TINY enabled" Ye Li
2020-03-31 9:40 ` Fabio Estevam
2020-03-31 12:01 ` Tom Rini [this message]
2020-04-07 21:37 ` Matt Porter
2020-04-09 8:28 ` [EXT] " Ye Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331120124.GT27133@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox