From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH 06/11] Nokia RX-51: Remove PART* macros
Date: Wed, 1 Apr 2020 00:35:13 +0200 [thread overview]
Message-ID: <20200331223518.10936-7-pali@kernel.org> (raw)
In-Reply-To: <20200331223518.10936-1-pali@kernel.org>
Now when code for defining partitions is duplicated at two locations
(option CONFIG_MTDPARTS_DEFAULT in nokia_rx51_defconfig file and macro
OMAP_TAG_PARTITION_CONFIG in rx51.c file) there is no need to have common
macros. Lets inline PART* macros to rx51.c file.
Signed-off-by: Pali Roh?r <pali@kernel.org>
---
board/nokia/rx51/rx51.c | 18 ++++++----------
include/configs/nokia_rx51.h | 42 ------------------------------------
2 files changed, 6 insertions(+), 54 deletions(-)
diff --git a/board/nokia/rx51/rx51.c b/board/nokia/rx51/rx51.c
index 80a0fc2696..c8ef26f940 100644
--- a/board/nokia/rx51/rx51.c
+++ b/board/nokia/rx51/rx51.c
@@ -69,18 +69,12 @@ static struct tag_omap omap[] = {
OMAP_TAG_GPIO_SWITCH_CONFIG("sleep_ind", 0xa2, 0x2, 0x2, 0x0),
OMAP_TAG_GPIO_SWITCH_CONFIG("slide", GPIO_SLIDE, 0x0, 0x0, 0x0),
OMAP_TAG_WLAN_CX3110X_CONFIG(0x25, 0xff, 87, 42, -1),
- OMAP_TAG_PARTITION_CONFIG(PART1_NAME, PART1_SIZE * PART1_MULL,
- PART1_OFFS, PART1_MASK),
- OMAP_TAG_PARTITION_CONFIG(PART2_NAME, PART2_SIZE * PART2_MULL,
- PART2_OFFS, PART2_MASK),
- OMAP_TAG_PARTITION_CONFIG(PART3_NAME, PART3_SIZE * PART3_MULL,
- PART3_OFFS, PART3_MASK),
- OMAP_TAG_PARTITION_CONFIG(PART4_NAME, PART4_SIZE * PART4_MULL,
- PART4_OFFS, PART4_MASK),
- OMAP_TAG_PARTITION_CONFIG(PART5_NAME, PART5_SIZE * PART5_MULL,
- PART5_OFFS, PART5_MASK),
- OMAP_TAG_PARTITION_CONFIG(PART6_NAME, PART6_SIZE * PART6_MULL,
- PART6_OFFS, PART6_MASK),
+ OMAP_TAG_PARTITION_CONFIG("bootloader", 128 * 1024, 0x00000000, 0x00000003),
+ OMAP_TAG_PARTITION_CONFIG("config", 384 * 1024, 0x00020000, 0x00000000),
+ OMAP_TAG_PARTITION_CONFIG("log", 256 * 1024, 0x00080000, 0x00000000),
+ OMAP_TAG_PARTITION_CONFIG("kernel", 2 * 1024*1024, 0x000c0000, 0x00000000),
+ OMAP_TAG_PARTITION_CONFIG("initfs", 2 * 1024*1024, 0x002c0000, 0x00000000),
+ OMAP_TAG_PARTITION_CONFIG("rootfs", 257280 * 1024, 0x004c0000, 0x00000000),
OMAP_TAG_BOOT_REASON_CONFIG("pwr_key"),
OMAP_TAG_VERSION_STR_CONFIG("product", "RX-51"),
OMAP_TAG_VERSION_STR_CONFIG("hw-build", "2101"),
diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h
index cfc4d0c1e5..a33b0a7ac8 100644
--- a/include/configs/nokia_rx51.h
+++ b/include/configs/nokia_rx51.h
@@ -91,48 +91,6 @@
* Board ONENAND Info.
*/
-#define PART1_NAME "bootloader"
-#define PART1_SIZE 128
-#define PART1_MULL 1024
-#define PART1_SUFF "k"
-#define PART1_OFFS 0x00000000
-#define PART1_MASK 0x00000003
-
-#define PART2_NAME "config"
-#define PART2_SIZE 384
-#define PART2_MULL 1024
-#define PART2_SUFF "k"
-#define PART2_OFFS 0x00020000
-#define PART2_MASK 0x00000000
-
-#define PART3_NAME "log"
-#define PART3_SIZE 256
-#define PART3_MULL 1024
-#define PART3_SUFF "k"
-#define PART3_OFFS 0x00080000
-#define PART3_MASK 0x00000000
-
-#define PART4_NAME "kernel"
-#define PART4_SIZE 2
-#define PART4_MULL 1024*1024
-#define PART4_SUFF "m"
-#define PART4_OFFS 0x000c0000
-#define PART4_MASK 0x00000000
-
-#define PART5_NAME "initfs"
-#define PART5_SIZE 2
-#define PART5_MULL 1024*1024
-#define PART5_SUFF "m"
-#define PART5_OFFS 0x002c0000
-#define PART5_MASK 0x00000000
-
-#define PART6_NAME "rootfs"
-#define PART6_SIZE 257280
-#define PART6_MULL 1024
-#define PART6_SUFF "k"
-#define PART6_OFFS 0x004c0000
-#define PART6_MASK 0x00000000
-
#define CONFIG_SYS_ONENAND_BASE ONENAND_MAP
/* Watchdog support */
--
2.20.1
next prev parent reply other threads:[~2020-03-31 22:35 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 22:35 [PATCH 00/11] Fixes for Nokia RX-51 Pali Rohár
2020-03-31 22:35 ` [PATCH 01/11] Nokia RX-51: Update my email address Pali Rohár
2020-03-31 22:35 ` [PATCH 02/11] Nokia RX-51: Add README.nokia_rx51 file to MAINTAINERS Pali Rohár
2020-03-31 22:35 ` [PATCH 03/11] Nokia RX-51: Move comment about CONFIG_SYS_TEXT_BASE to correct place Pali Rohár
2020-03-31 22:35 ` [PATCH 04/11] Nokia RX-51: Move code from defconfig back to C header file Pali Rohár
2020-03-31 22:35 ` [PATCH 05/11] Nokia RX-51: Revert back onenand defitions Pali Rohár
2020-03-31 22:35 ` Pali Rohár [this message]
2020-03-31 22:35 ` [PATCH 07/11] Nokia RX-51: Remember setup_console_atag option Pali Rohár
2020-03-31 22:35 ` [PATCH 08/11] Nokia RX-51: Enable CONFIG_CONSOLE_MUX Pali Rohár
2020-04-14 10:19 ` Lokesh Vutla
2020-03-31 22:35 ` [PATCH 09/11] Nokia RX-51: Disable some unused features to decrease size of u-boot binary Pali Rohár
2020-03-31 22:35 ` [PATCH 10/11] Nokia RX-51: Update README.nokia_rx51 Pali Rohár
2020-03-31 22:35 ` [PATCH 11/11] Nokia RX-51: Add automated test for running RX-51 build in qemu Pali Rohár
2020-04-14 10:40 ` Pali Rohár
2020-04-21 14:55 ` Lokesh Vutla
2020-04-21 17:36 ` Simon Glass
2020-04-21 20:12 ` Tom Rini
2020-04-21 20:37 ` Simon Glass
2020-04-21 20:46 ` Tom Rini
2020-04-21 20:49 ` Simon Glass
2020-04-21 20:51 ` Tom Rini
2020-04-21 21:34 ` Pali Rohár
2020-04-21 23:24 ` Tom Rini
2020-04-23 7:34 ` Pali Rohár
2020-04-23 12:24 ` Tom Rini
2020-04-23 17:48 ` Pali Rohár
2020-04-25 9:00 ` [PATCH v2] " Pali Rohár
2020-04-27 8:40 ` Pali Rohár
2020-04-27 18:00 ` Tom Rini
2020-04-28 7:37 ` Pali Rohár
2020-05-08 12:52 ` Pali Rohár
2020-05-08 13:10 ` Tom Rini
2020-05-09 16:28 ` Lokesh Vutla
2020-05-09 16:35 ` Pali Rohár
2020-05-09 20:56 ` Tom Rini
2020-05-14 22:41 ` Pali Rohár
2020-05-15 0:01 ` Tom Rini
2020-05-15 7:33 ` Pali Rohár
2020-05-15 13:20 ` Tom Rini
2020-05-15 13:46 ` Pali Rohár
2020-05-15 13:48 ` Tom Rini
2020-05-15 13:51 ` Pali Rohár
2020-05-15 13:53 ` Tom Rini
2020-05-15 13:58 ` Pali Rohár
2020-05-15 14:16 ` Tom Rini
2020-05-15 17:40 ` Pali Rohár
2020-05-15 18:34 ` Tom Rini
2020-05-17 12:31 ` Pali Rohár
2020-05-17 12:38 ` [PATCH v3] " Pali Rohár
2020-05-26 9:18 ` Pali Rohár
2020-05-26 9:22 ` Lokesh Vutla
2020-05-26 9:32 ` Pali Rohár
2020-05-26 9:33 ` Lokesh Vutla
2020-04-21 21:03 ` [PATCH 11/11] " Pali Rohár
2020-04-21 20:53 ` Pali Rohár
2020-03-31 22:42 ` U-Boot is broken on real N900 HW (Was: Re: [PATCH 00/11] Fixes for Nokia RX-51) Pali Rohár
[not found] ` <3c7dda52-10b3-e8c3-a382-785c80f124e7@wizzup.org>
2020-04-02 18:42 ` U-Boot is broken on real N900 HW Pali Rohár
2020-04-25 10:42 ` Pali Rohár
2020-04-25 11:36 ` Adam Ford
2020-04-25 11:50 ` Pali Rohár
2020-04-25 12:00 ` Adam Ford
2020-04-25 12:11 ` Pali Rohár
2020-04-25 23:54 ` U-Boot i2c bus num 1 is broken on Nokia N900 (Was: Re: U-Boot is broken on real N900 HW) Pali Rohár
2020-04-27 7:03 ` Heiko Schocher
2020-10-26 21:48 ` U-Boot i2c bus num 1 is broken on Nokia N900 Pali Rohár
2020-10-28 5:42 ` Heiko Schocher
2020-10-28 10:46 ` Pali Rohár
2020-10-29 7:51 ` Ivaylo Dimitrov
2020-10-29 9:32 ` Heiko Schocher
2020-10-29 9:36 ` Pali Rohár
2020-10-30 7:00 ` Ivaylo Dimitrov
2020-10-30 7:24 ` Heiko Schocher
2020-10-31 11:47 ` Ivaylo Dimitrov
2020-11-02 7:13 ` Heiko Schocher
2020-04-25 12:07 ` U-Boot is broken on real N900 HW Pali Rohár
2020-04-25 13:19 ` Pali Rohár
2020-04-25 13:48 ` Pali Rohár
2020-04-25 21:26 ` Bisected: mmc cause reboot loops on N900 (Was: Re: U-Boot is broken on real N900 HW) Pali Rohár
2020-04-25 22:20 ` Pali Rohár
2020-04-25 22:29 ` Bisected: omap_hsmmc 3.3V IO voltage incompatible with N900 (Was: Re: Bisected: mmc cause reboot loops on N900) Pali Rohár
2020-05-07 13:40 ` Faiz Abbas
2020-05-07 15:19 ` Pali Rohár
2020-05-26 17:49 ` Pali Rohár
2020-06-12 13:03 ` Pali Rohár
2020-07-01 8:32 ` Pali Rohár
2020-07-01 8:51 ` Faiz Abbas
2020-05-03 21:31 ` Bisected: mmc cause reboot loops on N900 Pali Rohár
2020-04-26 17:13 ` Bisected: mmc cause reboot loops on N900 (Was: Re: U-Boot is broken on real N900 HW) Pavel Machek
2020-04-06 20:12 ` U-Boot is broken on real N900 HW (Was: Re: [PATCH 00/11] Fixes for Nokia RX-51) Pavel Machek
2020-04-06 22:27 ` Pali Rohár
2020-04-13 10:41 ` [PATCH 00/11] Fixes for Nokia RX-51 Pali Rohár
2020-04-14 10:23 ` Lokesh Vutla
2020-04-14 10:31 ` Pali Rohár
2020-04-14 10:44 ` Lokesh Vutla
2020-04-14 11:17 ` Pali Rohár
2020-04-14 11:51 ` Lokesh Vutla
2020-04-14 12:01 ` Pali Rohár
2020-04-16 21:57 ` Pali Rohár
2020-04-20 8:12 ` Lokesh Vutla
2020-04-20 23:21 ` Pali Rohár
2020-05-11 12:47 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331223518.10936-7-pali@kernel.org \
--to=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox