* [PATCH] efi_loader: enable RNG if DM_RNG is enabled
@ 2020-04-01 10:15 Peter Robinson
2020-04-04 20:10 ` Sughosh Ganu
2020-04-05 9:39 ` Heinrich Schuchardt
0 siblings, 2 replies; 3+ messages in thread
From: Peter Robinson @ 2020-04-01 10:15 UTC (permalink / raw)
To: u-boot
Enable EFI_RNG_PROTOCOL by default if DM_RNG is set.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config
has enabled both DM_RNG and UEFI.
lib/efi_loader/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index 9890144d41..b9a770281e 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND
config EFI_RNG_PROTOCOL
bool "EFI_RNG_PROTOCOL support"
+ default y if DM_RNG
depends on DM_RNG
help
Provide a EFI_RNG_PROTOCOL implementation using the hardware random
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] efi_loader: enable RNG if DM_RNG is enabled
2020-04-01 10:15 [PATCH] efi_loader: enable RNG if DM_RNG is enabled Peter Robinson
@ 2020-04-04 20:10 ` Sughosh Ganu
2020-04-05 9:39 ` Heinrich Schuchardt
1 sibling, 0 replies; 3+ messages in thread
From: Sughosh Ganu @ 2020-04-04 20:10 UTC (permalink / raw)
To: u-boot
On Wed, 1 Apr 2020 at 15:45, Peter Robinson <pbrobinson@gmail.com> wrote:
> Enable EFI_RNG_PROTOCOL by default if DM_RNG is set.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>
> I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config
> has enabled both DM_RNG and UEFI.
>
Acked-by: Sughosh Ganu <sughosh.ganu@linaro.org>
-sughosh
>
> lib/efi_loader/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 9890144d41..b9a770281e 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND
>
> config EFI_RNG_PROTOCOL
> bool "EFI_RNG_PROTOCOL support"
> + default y if DM_RNG
> depends on DM_RNG
> help
> Provide a EFI_RNG_PROTOCOL implementation using the hardware
> random
> --
> 2.26.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] efi_loader: enable RNG if DM_RNG is enabled
2020-04-01 10:15 [PATCH] efi_loader: enable RNG if DM_RNG is enabled Peter Robinson
2020-04-04 20:10 ` Sughosh Ganu
@ 2020-04-05 9:39 ` Heinrich Schuchardt
1 sibling, 0 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2020-04-05 9:39 UTC (permalink / raw)
To: u-boot
On 4/1/20 12:15 PM, Peter Robinson wrote:
> Enable EFI_RNG_PROTOCOL by default if DM_RNG is set.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>
> I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config
> has enabled both DM_RNG and UEFI.
>
> lib/efi_loader/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 9890144d41..b9a770281e 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND
>
> config EFI_RNG_PROTOCOL
> bool "EFI_RNG_PROTOCOL support"
> + default y if DM_RNG
Thank you for your patch.
If you have 'depends on DM_RNG', there is not need for 'if DM RNG'.
You can use scripts/get_maintainer.pl to determine all addressees for a
patch (Alex was missing).
Otherwise
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> depends on DM_RNG
> help
> Provide a EFI_RNG_PROTOCOL implementation using the hardware random
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-05 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-01 10:15 [PATCH] efi_loader: enable RNG if DM_RNG is enabled Peter Robinson
2020-04-04 20:10 ` Sughosh Ganu
2020-04-05 9:39 ` Heinrich Schuchardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox