From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 01 Apr 2020 13:26:15 +0200 Subject: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment In-Reply-To: <20200331160456.26254-1-patrick.delaunay@st.com> References: <20200331180330.1.Ied6708bad5048382a57618f95d67c549aae49f42@changeid> <20200331160456.26254-1-patrick.delaunay@st.com> Message-ID: <20200401112615.931A024003E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Patrick Delaunay, In message <20200331160456.26254-1-patrick.delaunay@st.com> you wrote: > Imply CONFIG_VERSION_VARIABLE for stm32mp1 target > and test U-Boot version ($env_ver) when the environment was > saved for the last time and to display warning trace. What is env_ver? Are you by chance reinventing the wheel? The U-Boot version is stored in the environment variable "ver"; there should be no need for something similar. Also. where is $env_ver coming from? It does not exist in mainline, nor in any of the 3 patches that preceed this patch # 4/16 ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Computers are not intelligent. They only think they are.