From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 2/2] dm: core: Partial revert of "Allocate parent data separate from probing parent"
Date: Wed, 1 Apr 2020 16:57:59 +0300 [thread overview]
Message-ID: <20200401135759.13197-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200401135759.13197-1-andriy.shevchenko@linux.intel.com>
This reverts commit 82de42fa1468
("dm: core: Allocate parent data separate from probing parent")
as a being a culprit for Apollo Lake breakage.
Suggested-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/core/device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/core/device.c b/drivers/core/device.c
index 89ea820d48..400767d9bd 100644
--- a/drivers/core/device.c
+++ b/drivers/core/device.c
@@ -392,10 +392,6 @@ int device_probe(struct udevice *dev)
drv = dev->driver;
assert(drv);
- ret = device_ofdata_to_platdata(dev);
- if (ret)
- goto fail;
-
/* Ensure all parents are probed */
if (dev->parent) {
ret = device_probe(dev->parent);
@@ -412,6 +408,10 @@ int device_probe(struct udevice *dev)
return 0;
}
+ ret = device_ofdata_to_platdata(dev);
+ if (ret)
+ goto fail;
+
seq = uclass_resolve_seq(dev);
if (seq < 0) {
ret = seq;
--
2.25.1
next prev parent reply other threads:[~2020-04-01 13:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 13:57 [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()" Andy Shevchenko
2020-04-01 13:57 ` Andy Shevchenko [this message]
2020-04-01 14:32 ` Bin Meng
2020-04-01 14:45 ` Andy Shevchenko
2020-04-01 16:56 ` Simon Glass
2020-04-01 17:39 ` Andy Shevchenko
2020-04-01 17:54 ` Simon Glass
2020-04-02 4:55 ` Bin Meng
2020-04-02 12:45 ` Tom Rini
2020-04-02 16:27 ` Ang, Chee Hong
2020-04-02 18:39 ` Andy Shevchenko
2020-04-03 3:55 ` Ang, Chee Hong
2020-04-03 7:33 ` Andy Shevchenko
2020-04-03 7:55 ` Ang, Chee Hong
2020-04-03 8:24 ` Andy Shevchenko
2020-04-03 14:30 ` Simon Glass
2020-04-02 19:09 ` Andy Shevchenko
2020-04-03 7:32 ` Andy Shevchenko
2020-04-03 8:26 ` Antwort: " Wolfgang Wallner
2020-04-03 8:35 ` Bin Meng
2020-04-03 8:45 ` Andy Shevchenko
2020-04-06 3:43 ` Simon Glass
2020-04-06 4:13 ` Bin Meng
2020-04-06 14:24 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401135759.13197-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox