From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Wed, 1 Apr 2020 20:39:03 +0300 Subject: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()" In-Reply-To: References: <20200401135759.13197-1-andriy.shevchenko@linux.intel.com> Message-ID: <20200401173903.GV1922688@smile.fi.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Apr 01, 2020 at 10:56:26AM -0600, Simon Glass wrote: > Hi Andy, > > On Wed, 1 Apr 2020 at 08:45, Andy Shevchenko wrote: > > > > On Wed, Apr 1, 2020 at 5:32 PM Bin Meng wrote: > > > On Wed, Apr 1, 2020 at 9:58 PM Andy Shevchenko > > > wrote: > > > > > > > > The commit breaks serial console on the Intel Edison. > > > > > > > > This reverts commit 720f9e1fdb0c92d3fd16e1bfc25bcbd35612675c. > > > > > > > > Signed-off-by: Andy Shevchenko > > > > --- > > > > drivers/serial/ns16550.c | 40 ++++++++++++---------------------------- > > > > 1 file changed, 12 insertions(+), 28 deletions(-) > > > > > > > > > > Could you please spend some time to investigate why this breaks Intel Edison? > > > > > > Reverting this patch would mean we break other boards too as > > > Wolfgang's patch wanted to fix the breakage in the first place. Much > > > appreciated! > > > > I guess I'm wrong person here. The DM code is a complete black box to me. > > Nevertheless, I may test any provided fix / debug / etc patch by request. > > > > And I think it's fair to investigate by the one who made a regression > > in the first place. > > Given that we have conflicting breakages, we need to debug Edison. I would glad to test any suggested change or debug patch! > Does it enable the debug UART? If I am not mistaken, it does not. -- With Best Regards, Andy Shevchenko