From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH] serial: ns16550: Fix ordering of getting base address
Date: Fri, 3 Apr 2020 13:56:55 +0300 [thread overview]
Message-ID: <20200403105655.GN1922688@smile.fi.intel.com> (raw)
In-Reply-To: <CAEUhbmXaaUrMn=cDQDcP+DnOr-49h1B-m34u1VU4RkZgDKonuA@mail.gmail.com>
On Fri, Apr 03, 2020 at 06:16:51PM +0800, Bin Meng wrote:
> On Fri, Apr 3, 2020 at 6:05 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Apr 03, 2020 at 02:58:08AM -0700, Bin Meng wrote:
...
> > > Fixes: 720f9e1fdb0c9 ("serial: ns16550: Move PCI access from
> > > ofdata_to_platdata() to probe()")
> >
> > I believe this should be one line.
>
> I thought putting it in one line violates the 80 characters per column
> rule. And checkpatch.pl does not complain about this, so I think it's
> fine :)
Breaking tags to two or more lines actually breaks the scripts around this stuff.
JFYI, in Linux kernel it was now in documentation (not to break Fixes, etc to
two or more lines).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-03 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 9:58 [PATCH] serial: ns16550: Fix ordering of getting base address Bin Meng
2020-04-03 10:05 ` Andy Shevchenko
2020-04-03 10:16 ` Bin Meng
2020-04-03 10:56 ` Andy Shevchenko [this message]
2020-04-03 11:47 ` Antwort: " Wolfgang Wallner
2020-04-03 12:33 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403105655.GN1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox