From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: Antwort: [PATCH v3 11/29] x86: apl: Add Global NVS table header
Date: Fri, 3 Apr 2020 14:25:44 +0300 [thread overview]
Message-ID: <20200403112544.GR1922688@smile.fi.intel.com> (raw)
In-Reply-To: <OFFCCADBE4.88CD43D4-ONC125853C.002C8638-C125853C.002CA4C1@br-automation.com>
On Tue, Mar 31, 2020 at 10:07:37AM +0200, Wolfgang Wallner wrote:
> >+struct __packed acpi_global_nvs {
> >+ /* Miscellaneous */
> >+ u8 pcnt; /* 0x00 - Processor Count */
> >+ u8 ppcm; /* 0x01 - Max PPC State */
> >+ u8 lids; /* 0x02 - LID State */
> >+ u8 pwrs; /* 0x03 - AC Power State */
> >+ u8 dpte; /* 0x04 - Enable DPTF */
> >+ u32 cbmc; /* 0x05 - 0x08 - U-Boot Console */
> >+ u64 pm1i; /* 0x09 - 0x10 - System Wake Source - PM1 Index */
> >+ u64 gpei; /* 0x11 - 0x18 - GPE Wake Source */
> >+ u64 nhla; /* 0x19 - 0x20 - NHLT Address */
> >+ u32 nhll; /* 0x21 - 0x24 - NHLT Length */
> >+ u32 prt0; /* 0x25 - 0x28 - PERST_0 Address */
> >+ u8 scdp; /* 0x29 - SD_CD GPIO portid */
> >+ u8 scdo; /* 0x2A - GPIO pad offset relative to the community */
> >+ u8 uior; /* 0x2B - UART debug controller init on S3 resume */
> >+ u8 ecps; /* 0x2C - SGX Enabled status */
> >+ u64 emna; /* 0x2D - 0x34 EPC base address */
> >+ u64 elng; /* 0x35 - 0x3C EPC Length */
> >+ u8 unused[195];
> >+ u8 unused2[0xf00];
>
> Nit 1: Something is still wrong with the indentation of unused2.
>
> Nit 2: Could you please add comments on why the values 195 and 0xf00 were
> chosen? I would assume 195 was selected so that unused2 starts on
> a 256-byte boundary? But that is only a guess.
Better to calculate them (I mean 195). In Linux kernel, for instance, a trick
is being used for that.
The rest is not simply boundary but rather 256 vs 4096 size of NVS. The
previous (small one) is what being used by U-Boot. I don't remember what ACPI
spec dictates about this (i.o.w. if it depends to the ACPI version in use).
> >+};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-03 11:25 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 23:12 [PATCH v3 00/29] dm: Add programmatic generation of ACPI tables (part A) Simon Glass
2020-03-30 23:12 ` [PATCH v3 01/29] cpu: Support querying the address width Simon Glass
2020-03-30 23:12 ` [PATCH v3 02/29] spi: Add SPI mode enums Simon Glass
2020-03-30 23:12 ` [PATCH v3 03/29] tpm: cr50: Release locality on exit Simon Glass
2020-03-30 23:12 ` [PATCH v3 04/29] tpm: cr50: Add a comment for cr50_priv Simon Glass
2020-03-30 23:12 ` [PATCH v3 05/29] tpm: cr50: Use the correct GPIO binding Simon Glass
2020-03-30 23:12 ` [PATCH v3 06/29] tpm: Don't cleanup unless an error happens Simon Glass
2020-03-30 23:12 ` [PATCH v3 07/29] dm: pci: Allow disabling auto-config for a device Simon Glass
2020-03-30 23:12 ` [PATCH v3 08/29] x86: Correct wording of coreboot source code Simon Glass
2020-03-30 23:12 ` [PATCH v3 09/29] x86: apl: Move p2sb ofdata reading to the correct method Simon Glass
2020-03-30 23:12 ` [PATCH v3 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly Simon Glass
2020-04-03 11:22 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 16:58 ` Andy Shevchenko
2020-04-08 22:15 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 11/29] x86: apl: Add Global NVS table header Simon Glass
2020-03-31 8:07 ` Antwort: " Wolfgang Wallner
2020-04-03 11:25 ` Andy Shevchenko [this message]
2020-03-30 23:12 ` [PATCH v3 12/29] dm: core: Add basic ACPI support Simon Glass
2020-03-31 8:16 ` Antwort: " Wolfgang Wallner
2020-04-03 11:35 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 17:01 ` Andy Shevchenko
2020-04-08 22:15 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 13/29] dts: Add a binding for hid-over-i2c Simon Glass
2020-03-31 19:25 ` Antwort: " Wolfgang Wallner
2020-04-01 7:39 ` Wolfgang Wallner
2020-04-08 2:57 ` Simon Glass
2020-04-08 2:58 ` Simon Glass
2020-04-08 17:08 ` Andy Shevchenko
2020-04-08 19:39 ` Antwort: " Wolfgang Wallner
2020-04-08 20:40 ` Andy Shevchenko
2020-04-08 20:49 ` Andy Shevchenko
2020-04-15 14:00 ` Antwort: Re: " Wolfgang Wallner
2020-04-15 14:25 ` Andy Shevchenko
2020-04-15 14:57 ` Antwort: Re: Re: " Wolfgang Wallner
2020-04-15 15:15 ` Andy Shevchenko
2020-04-15 15:17 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 14/29] acpi: Add a binding for ACPI settings in the device tree Simon Glass
2020-04-03 12:42 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 15/29] acpi: Add a simple sandbox test Simon Glass
2020-04-03 12:51 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 16:57 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 16/29] x86: Move acpi_s3.h to include/acpi/ Simon Glass
2020-04-03 12:53 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 17:03 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 17/29] x86: Move acpi_table header to main include/ directory Simon Glass
2020-04-03 12:58 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 17:04 ` Andy Shevchenko
2020-04-08 22:15 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 18/29] acpi: Add an __ACPI__ preprocessor symbol Simon Glass
2020-03-30 23:12 ` [PATCH v3 19/29] acpi: Add a central location for table version numbers Simon Glass
2020-03-31 19:30 ` Antwort: " Wolfgang Wallner
2020-04-08 2:58 ` Simon Glass
2020-04-03 13:04 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 20/29] acpi: Add support for DMAR Simon Glass
2020-03-31 19:34 ` Antwort: " Wolfgang Wallner
2020-04-03 13:15 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 21/29] test: Add hexdump.h to the unit test header Simon Glass
2020-04-06 11:53 ` Antwort: " Wolfgang Wallner
2020-03-30 23:12 ` [PATCH v3 22/29] acpi: Add a method to write tables for a device Simon Glass
2020-04-03 13:20 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 23/29] acpi: Convert part of acpi_table to use acpi_ctx Simon Glass
2020-04-03 13:24 ` Andy Shevchenko
2020-04-03 13:25 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-03-30 23:13 ` [PATCH v3 24/29] x86: Allow devices to write ACPI tables Simon Glass
2020-03-30 23:13 ` [PATCH v3 25/29] acpi: Drop code for missing XSDT from acpi_write_rsdp() Simon Glass
2020-03-30 23:13 ` [PATCH v3 26/29] acpi: Move acpi_add_table() to generic code Simon Glass
2020-03-30 23:13 ` [PATCH v3 27/29] acpi: Put table-setup code in its own function Simon Glass
2020-04-03 13:32 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 17:11 ` Andy Shevchenko
2020-04-08 19:35 ` Simon Glass
2020-03-30 23:13 ` [PATCH v3 28/29] acpi: Move the xsdt pointer to acpi_ctx Simon Glass
2020-03-30 23:13 ` [PATCH v3 29/29] acpi: Add an acpi command Simon Glass
2020-03-31 18:14 ` Leif Lindholm
2020-04-03 13:41 ` Andy Shevchenko
2020-04-03 13:39 ` Andy Shevchenko
2020-03-31 6:31 ` [PATCH v3 00/29] dm: Add programmatic generation of ACPI tables (part A) Heinrich Schuchardt
2020-04-02 2:34 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403112544.GR1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox