public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] usb: Keep async schedule running only across mass storage xfers
Date: Mon, 6 Apr 2020 08:35:04 -0400	[thread overview]
Message-ID: <20200406123504.GL27133@bill-the-cat> (raw)
In-Reply-To: <20200406122944.105432-1-marek.vasut+renesas@gmail.com>

On Mon, Apr 06, 2020 at 02:29:44PM +0200, Marek Vasut wrote:

> Rather than keeping the asynchronous schedule running always, keep it
> running only across USB mass storage transfers for now, as it seems
> that keeping it running all the time interferes with certain control
> transfers during device enumeration.
> 
> Note that running the async schedule all the time should not be an
> issue, especially on EHCI HCD, as that one implements most of the
> transfers using async schedule.
> 
> Note that we have usb_disable_asynch(), which however is utterly broken.
> The usb_disable_asynch() blocks the USB core from doing async transfers
> by setting a global flag. The async schedule should however be disabled
> per USB controller. Moreover, setting a global flag does not prevent the
> controller from using the async schedule, which e.g. the EHCI HCD does.
> 
> This patch implements additional callback to the controller, which
> permits it to lock the async schedule and keep it running across
> multiple transfers. Once the schedule is unlocked, it must also be
> disabled. This thus prevents the async schedule from running outside
> of the USB mass storage transfers.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Tom Rini <trini@konsulko.com>

Tested-by: Tom Rini <trini@konsulko.com> [omap3_beagle, previously failing]

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200406/59f68a95/attachment.sig>

  reply	other threads:[~2020-04-06 12:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 12:29 [PATCH] usb: Keep async schedule running only across mass storage xfers Marek Vasut
2020-04-06 12:35 ` Tom Rini [this message]
2020-04-09 23:23 ` Tom Rini
2020-04-10  6:21   ` Lukasz Majewski
2020-04-10 12:40     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406123504.GL27133@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox