public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Matt Porter <mporter@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] Revert "common: spl_fit: Default to IH_OS_U_BOOT if FIT_IMAGE_TINY enabled"
Date: Tue, 7 Apr 2020 17:37:30 -0400	[thread overview]
Message-ID: <20200407213730.GA14950@bacon.ohporter.com> (raw)
In-Reply-To: <1585645160-108428-1-git-send-email-ye.li@nxp.com>

On Tue, Mar 31, 2020 at 01:59:20AM -0700, Ye Li wrote:
> The patch in commit cf8dcc5d02c32173b74bf1b7600dd2b990a90b13 is not correct,
> it will append fdt to each loadable image.
> Actually when using TINY FIT, the first loadable image is thought as u-boot
> and already have fdt appended.
> 
> Signed-off-by: Ye Li <ye.li@nxp.com>

Hi,

I just rebased an i.mx8mm board from v2020.04-rc4 to v2020.04-rc5 that
I'm preparing for submission upstream and noticed that this commit
broke start of U-Boot. Reverting this or disabling FIT_IMAGE_TINY fixes
it.

-Matt

> ---
>  common/spl/spl_fit.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
> index aef1dbd..69dabd2 100644
> --- a/common/spl/spl_fit.c
> +++ b/common/spl/spl_fit.c
> @@ -646,10 +646,6 @@ int spl_load_simple_fit(struct spl_image_info *spl_image,
>  
>  		if (!spl_fit_image_get_os(fit, node, &os_type))
>  			debug("Loadable is %s\n", genimg_get_os_name(os_type));
> -#if CONFIG_IS_ENABLED(FIT_IMAGE_TINY)
> -		else
> -			os_type = IH_OS_U_BOOT;
> -#endif
>  
>  		if (os_type == IH_OS_U_BOOT) {
>  			spl_fit_append_fdt(&image_info, info, sector,
> -- 
> 2.7.4
> 

  parent reply	other threads:[~2020-04-07 21:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31  8:59 [PATCH] Revert "common: spl_fit: Default to IH_OS_U_BOOT if FIT_IMAGE_TINY enabled" Ye Li
2020-03-31  9:40 ` Fabio Estevam
2020-03-31 12:01   ` Tom Rini
2020-04-07 21:37 ` Matt Porter [this message]
2020-04-09  8:28   ` [EXT] " Ye Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407213730.GA14950@bacon.ohporter.com \
    --to=mporter@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox