public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 16/26 v6] tools: binman: add etype file for u-boot-lzma-img
Date: Wed,  8 Apr 2020 10:09:32 +0200	[thread overview]
Message-ID: <20200408080942.7694-17-sr@denx.de> (raw)
In-Reply-To: <20200408080942.7694-1-sr@denx.de>

From: Weijie Gao <weijie.gao@mediatek.com>

This patch adds etype u-boot-lzma-img for binman. README.entries is also
updated.

Reviewed-by: Stefan Roese <sr@denx.de>
Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
Changes since v3: none

 tools/binman/README.entries               | 15 ++++++++++++
 tools/binman/etype/u_boot_lzma_img.py     | 28 +++++++++++++++++++++++
 tools/binman/ftest.py                     |  7 ++++++
 tools/binman/test/156_u_boot_lzma_img.dts | 11 +++++++++
 4 files changed, 61 insertions(+)
 create mode 100644 tools/binman/etype/u_boot_lzma_img.py
 create mode 100644 tools/binman/test/156_u_boot_lzma_img.dts

diff --git a/tools/binman/README.entries b/tools/binman/README.entries
index 6a816bba6b..0aea9b8f6d 100644
--- a/tools/binman/README.entries
+++ b/tools/binman/README.entries
@@ -747,6 +747,21 @@ applications.
 
 
 
+Entry: u-boot-lzma-img: U-Boot legacy image with contents compressed by LZMA
+----------------------------------------------------------------------------
+
+Properties / Entry arguments:
+    - filename: Filename of u-boot-lzma.img (default 'u-boot-lzma.img')
+
+This is the U-Boot binary as a packaged image, in legacy format. It has a
+header which allows it to be loaded at the correct address for execution.
+Its contents are compressed by LZMA.
+
+You should use FIT (Flat Image Tree) instead of the legacy image for new
+applications.
+
+
+
 Entry: u-boot-nodtb: U-Boot flat binary without device tree appended
 --------------------------------------------------------------------
 
diff --git a/tools/binman/etype/u_boot_lzma_img.py b/tools/binman/etype/u_boot_lzma_img.py
new file mode 100644
index 0000000000..966d6a46da
--- /dev/null
+++ b/tools/binman/etype/u_boot_lzma_img.py
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2020 MediaTek Inc. All Rights Reserved.
+# Author: Weijie Gao <weijie.gao@mediatek.com>
+#
+# Entry-type module for U-Boot legacy image with contents compressed by LZMA
+#
+
+from entry import Entry
+from blob import Entry_blob
+
+class Entry_u_boot_lzma_img(Entry_blob):
+    """U-Boot legacy image with contents compressed by LZMA
+
+    Properties / Entry arguments:
+        - filename: Filename of u-boot-lzma.img (default 'u-boot-lzma.img')
+
+    This is the U-Boot binary as a packaged image, in legacy format. It has a
+    header which allows it to be loaded at the correct address for execution.
+    Its contents are compressed by LZMA.
+
+    You should use FIT (Flat Image Tree) instead of the legacy image for new
+    applications.
+    """
+    def __init__(self, section, etype, node):
+        Entry_blob.__init__(self, section, etype, node)
+
+    def GetDefaultFilename(self):
+        return 'u-boot-lzma.img'
diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py
index 872b855444..0ff7487b96 100644
--- a/tools/binman/ftest.py
+++ b/tools/binman/ftest.py
@@ -39,6 +39,7 @@ import tout
 # Contents of test files, corresponding to different entry types
 U_BOOT_DATA           = b'1234'
 U_BOOT_IMG_DATA       = b'img'
+U_BOOT_LZMA_IMG_DATA  = b'lzma-img'
 U_BOOT_SPL_DATA       = b'56780123456789abcdefghi'
 U_BOOT_TPL_DATA       = b'tpl9876543210fedcbazyw'
 BLOB_DATA             = b'89'
@@ -115,6 +116,7 @@ class TestFunctional(unittest.TestCase):
         # Create some test files
         TestFunctional._MakeInputFile('u-boot.bin', U_BOOT_DATA)
         TestFunctional._MakeInputFile('u-boot.img', U_BOOT_IMG_DATA)
+        TestFunctional._MakeInputFile('u-boot-lzma.img', U_BOOT_LZMA_IMG_DATA)
         TestFunctional._MakeInputFile('spl/u-boot-spl.bin', U_BOOT_SPL_DATA)
         TestFunctional._MakeInputFile('tpl/u-boot-tpl.bin', U_BOOT_TPL_DATA)
         TestFunctional._MakeInputFile('blobfile', BLOB_DATA)
@@ -1078,6 +1080,11 @@ class TestFunctional(unittest.TestCase):
         data = self._DoReadFile('036_u_boot_img.dts')
         self.assertEqual(U_BOOT_IMG_DATA, data)
 
+    def testUBootLzmaImg(self):
+        """Test that u-boot-lzma.img can be put in a file"""
+        data = self._DoReadFile('156_u_boot_lzma_img.dts')
+        self.assertEqual(U_BOOT_LZMA_IMG_DATA, data)
+
     def testNoMicrocode(self):
         """Test that a missing microcode region is detected"""
         with self.assertRaises(ValueError) as e:
diff --git a/tools/binman/test/156_u_boot_lzma_img.dts b/tools/binman/test/156_u_boot_lzma_img.dts
new file mode 100644
index 0000000000..f49d014216
--- /dev/null
+++ b/tools/binman/test/156_u_boot_lzma_img.dts
@@ -0,0 +1,11 @@
+/dts-v1/;
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
+	binman {
+		u-boot-lzma-img {
+		};
+	};
+};
-- 
2.26.0

  parent reply	other threads:[~2020-04-08  8:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  8:09 [PATCH 00/26 v6] Refactor the architecture parts of mt7628 Stefan Roese
2020-04-08  8:09 ` [PATCH 01/26 v6] mips: add support to restore exception vector base before booting linux Stefan Roese
2020-04-08  8:09 ` [PATCH 02/26 v6] mips: mtmips: add predefined i-cache/d-cache size and linesize Stefan Roese
2020-04-08  8:09 ` [PATCH 03/26 v6] mips: add an option to support initialize SRAM for initial stack Stefan Roese
2020-04-08  8:09 ` [PATCH 04/26 v6] mips: start.S: avoid overwriting outside gd when clearing global data in stack Stefan Roese
2020-04-08  8:09 ` [PATCH 05/26 v6] sysreset: add reset controller based reboot driver Stefan Roese
2020-04-08  8:09 ` [PATCH 06/26 v6] mips: mtmips: make use of sysreset-resetctrl for mt7628 soc Stefan Roese
2020-04-08  8:09 ` [PATCH 07/26 v6] configs: enable CONFIG_RESTORE_EXCEPTION_VECTOR_BASE for all mtmips boards Stefan Roese
2020-04-08  8:09 ` [PATCH 08/26 v6] mips: add a mtmips-specific field to architecture-specific global data Stefan Roese
2020-04-08  8:09 ` [PATCH 09/26 v6] mips: add a option to support not reserving malloc space on initial stack Stefan Roese
2020-04-08  8:09 ` [PATCH 10/26 v6] mips: mtmips: rewrite lowlevel codes of mt7628 Stefan Roese
2020-04-08  8:09 ` [PATCH 11/26 v6] dts: mtmips: add alternative pinmux node for uart2 Stefan Roese
2020-04-08  8:09 ` [PATCH 12/26 v6] mips: enable support for appending dtb to spl binary Stefan Roese
2020-04-08  8:09 ` [PATCH 13/26 v6] mips: add an option to enable u_boot_list section for SPL loaders in u-boot-spl.lds Stefan Roese
2020-04-08  8:09 ` [PATCH 14/26 v6] lib: enable lzma decompression support for SPL build Stefan Roese
2020-04-08  8:09 ` [PATCH 15/26 v6] Makefile: add support to generate LZMA compressed u-boot image Stefan Roese
2020-04-08  8:09 ` Stefan Roese [this message]
2020-04-08  8:09 ` [PATCH 17/26 v6] spl: Extract legacy image handling into separate file Stefan Roese
2020-04-08  8:09 ` [PATCH 18/26 v6] spl: spl_legacy: Use IS_ENABLED() to remove #ifdef Stefan Roese
2020-04-08  8:09 ` [PATCH 19/26 v6] spl: spl_nor: Copy image header to local struct Stefan Roese
2020-04-09  7:24   ` Simon Goldschmidt
2020-04-08  8:09 ` [PATCH 20/26 v6] spl: spl_nor: Move legacy image loading into spl_legacy.c Stefan Roese
2020-04-09 18:51   ` Daniel Schwierzeck
2020-04-10  8:02     ` Stefan Roese
2020-04-08  8:09 ` [PATCH 21/26 v6] spl: spl_legacy: Add lzma decompression support for legacy image Stefan Roese
2020-04-08  8:09 ` [PATCH 22/26 v6] spl: spl_legacy: Add cache flush after reading U-Boot image Stefan Roese
2020-04-09  7:29   ` Simon Goldschmidt
2020-04-09  7:43     ` Stefan Roese
2020-04-09 16:47       ` Daniel Schwierzeck
2020-04-10  7:50         ` Stefan Roese
2020-04-09 18:15       ` Simon Goldschmidt
2020-04-08  8:09 ` [PATCH 23/26 v6] mips: mtmips: add SPL support Stefan Roese
2020-04-08  8:09 ` [PATCH 24/26 v6] mips: mtmips: enable SPL for all boards Stefan Roese
2020-04-08  8:09 ` [PATCH 25/26 v6] mips: mtmips: add support for mt7628-rfb Stefan Roese
2020-04-08  8:09 ` [PATCH 26/26 v6] mips: mtmips: Increase CONFIG_SPL_SYS_MALLOC_F_LEN Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200408080942.7694-17-sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox