Antwort: [PATCH v3 19/29] acpi: Add a central location for table version numbers

Wolfgang Wallner
2020-03-31T19:30:30Z

Hi Simon,

-----"Simon Glass" <sjg@chromium.org> schrieb: -----

>Betreff: [PATCH v3 19/29] acpi: Add a central location for table
>version numbers
>
>Each ACPI table has its own version number. Add the version numbers
>in a
>single function so we can keep them consistent and easily see what
>versions are supported.
>
>Start a new acpi_table file in a generic directory to house this
>function.
>We can move things over to this file from x86 as needed.
>
>Signed-off-by: Simon Glass <sjg@chromium.org>
>---
>
>Changes in v3:
>- Fix a few typos
>- Fix file comment for acpi_table.c
>
>Changes in v2:
>- Move the sandbox acpi_table.h header file to an earlier patch
>- Use #defines for MADT and MCFG version numbers
>
> include/acpi/acpi_table.h | 61
>+++++++++++++++++++++++++++++++++++++++
> lib/Makefile | 1 +
> lib/acpi/Makefile | 4 +++
> lib/acpi/acpi_table.c | 60
>++++++++++++++++++++++++++++++++++++++
> test/dm/acpi.c | 14 +++++++++
> 5 files changed, 140 insertions(+)
> create mode 100644 lib/acpi/Makefile
> create mode 100644 lib/acpi/acpi_table.c
>
>diff --git a/include/acpi/acpi_table.h b/include/acpi/acpi_table.h
>index dd748958136..ccf6fa04dbe 100644
>--- a/include/acpi/acpi_table.h
>+++ b/include/acpi/acpi_table.h
>@@ -202,6 +202,26 @@ struct __packed acpi_fadt {
> struct acpi_gen_regaddr x_gpe1_blk;
> };
>

[snip]

> #include <asm/acpi_table.h>
>diff --git a/lib/Makefile b/lib/Makefile
>index 15259d0473c..f737eb559fc 100644
>--- a/lib/Makefile
>+++ b/lib/Makefile
>@@ -5,6 +5,7 @@
>
> ifndef CONFIG_SPL_BUILD
>
>+obj-$(CONFIG_$(SPL_)ACPIGEN) += acpi/

Could you please help me understand why $(SPL_) is used here?
You have mentioned in your answer of the v2 patch explicitly that you should
use $SPL_ here and have changed the patch accordingly in v3, so I trust that
it makes sense. But I fail to understand how this works. The newly added line
is within "ifndef CONFIG_SPL_BUILD", in which case $SPL_ should alwys be empty
anyway. At least that is how I understood the assigment to SPL_ in Makefile.spl.

> obj-$(CONFIG_EFI) += efi/
> obj-$(CONFIG_EFI_LOADER) += efi_driver/
> obj-$(CONFIG_EFI_LOADER) += efi_loader/

[snip]

Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>