[PATCH v3 17/29] x86: Move acpi_table header to main include/ directory

Simon Glass
2020-04-08T02:57:27Z

Hi Andy,

On Fri, 3 Apr 2020 at 06:58, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Mar 30, 2020 at 05:12:53PM -0600, Simon Glass wrote:
> > This file is potentially useful to other architectures saddled with ACPI
> > so move most of its contents to a common location.
>
> It's not just potentially, it's definitely useful.
> But this makes me think, why we don't incorporate ACPICA headers as is?

Due to code style and the vast amount of unused code.

>
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> > Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > ---
> >
> > Changes in v3:
> > - Add forward declarations for the functions
> > - Move acpi_table.h to include/acpi
> > - Update commit message to say that we move most of its contents
> >
> > Changes in v2: None
> >
> > arch/x86/cpu/baytrail/acpi.c | 2 +-
> > arch/x86/cpu/cpu.c | 2 +-
> > arch/x86/cpu/quark/acpi.c | 2 +-
> > arch/x86/cpu/tangier/acpi.c | 4 +-
> > arch/x86/include/asm/acpi_table.h | 381 +----------------------------
> > arch/x86/lib/acpi.c | 2 +-
> > arch/x86/lib/acpi_s3.c | 2 +-
> > arch/x86/lib/acpi_table.c | 2 +-
> > arch/x86/lib/tables.c | 2 +-
> > arch/x86/lib/zimage.c | 2 +-
> > include/acpi/acpi_table.h | 394 ++++++++++++++++++++++++++++++
> > lib/efi_loader/efi_acpi.c | 2 +-
> > 12 files changed, 412 insertions(+), 385 deletions(-)
> > create mode 100644 include/acpi/acpi_table.h
> >

Regards,
Simon