[PATCH v3 27/29] acpi: Put table-setup code in its own function

Simon Glass
2020-04-08T19:35:00Z

Hi Andy,

On Wed, 8 Apr 2020 at 11:11, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Apr 07, 2020 at 08:57:52PM -0600, Simon Glass wrote:
> > On Fri, 3 Apr 2020 at 07:32, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > On Mon, Mar 30, 2020 at 05:13:03PM -0600, Simon Glass wrote:
> > > > We always write three basic tables to ACPI at the start. Move this into
> > > > its own function, along with acpi_fill_header(), so we can write a test
> > > > for this code.
> > >
> > > ...
> > >
> > > > /* Re-calculate checksum */
> > > > rsdt->header.checksum = 0;
> > > > - rsdt->header.checksum = table_compute_checksum((u8 *)rsdt,
> > > > + rsdt->header.checksum = table_compute_checksum(rsdt,
> > > > rsdt->header.length);
> >
> > Please can you keep the filenames / functions in your response?
> > Fragments make it harder to find the code.
>
> I thought, obviously mistakenly, that git users know about git grep ...

Well I'd appreciate it if you could keep them in. It is customary, and
it avoids grepping as you say.

>
> > > Why suddenly casting is not needed in this patch?
> > > Same question to the rest.
> > >
> > > (If it's a valid change, it should be in a separate patch)
> >
> > It was never needed. See the prototype for table_compute_checksum().
> >
> > But I can put it back in.
>
> Depends on your preferences, but it's definitely not a material for this
> change. Separate one?

It isn't worth worrying about as a later commit drops it. Let's just
leave it as you had it, with the cast.

Regards,
Simon