From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 16/29] x86: Move acpi_s3.h to include/acpi/
Date: Wed, 8 Apr 2020 20:03:20 +0300 [thread overview]
Message-ID: <20200408170320.GL3676135@smile.fi.intel.com> (raw)
In-Reply-To: <CAPnjgZ0nyK-hWwbyKUyYeuzUVGAi0+OvON4JkPR-s-xzN-ynWw@mail.gmail.com>
On Tue, Apr 07, 2020 at 08:57:25PM -0600, Simon Glass wrote:
> On Fri, 3 Apr 2020 at 06:53, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Mar 30, 2020 at 05:12:52PM -0600, Simon Glass wrote:
> > > This header relates to ACPI and we are about to add some more ACPI
> > > headers. Move this one into a new directory so they are together.
> > >
> >
> > FWIW,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > One nit below.
> > > -#ifdef CONFIG_X86
> >
> > There is nothing in commit message about this change. Is it safe? Don't you get
> > new compiler warnings (like defined-but-not-used)?
>
> Not that I can see. Since it isn't specific to x86 anymore it seems
> like a good idea to remove this #ifdef
Please mention in commit message.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-08 17:03 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 23:12 [PATCH v3 00/29] dm: Add programmatic generation of ACPI tables (part A) Simon Glass
2020-03-30 23:12 ` [PATCH v3 01/29] cpu: Support querying the address width Simon Glass
2020-03-30 23:12 ` [PATCH v3 02/29] spi: Add SPI mode enums Simon Glass
2020-03-30 23:12 ` [PATCH v3 03/29] tpm: cr50: Release locality on exit Simon Glass
2020-03-30 23:12 ` [PATCH v3 04/29] tpm: cr50: Add a comment for cr50_priv Simon Glass
2020-03-30 23:12 ` [PATCH v3 05/29] tpm: cr50: Use the correct GPIO binding Simon Glass
2020-03-30 23:12 ` [PATCH v3 06/29] tpm: Don't cleanup unless an error happens Simon Glass
2020-03-30 23:12 ` [PATCH v3 07/29] dm: pci: Allow disabling auto-config for a device Simon Glass
2020-03-30 23:12 ` [PATCH v3 08/29] x86: Correct wording of coreboot source code Simon Glass
2020-03-30 23:12 ` [PATCH v3 09/29] x86: apl: Move p2sb ofdata reading to the correct method Simon Glass
2020-03-30 23:12 ` [PATCH v3 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly Simon Glass
2020-04-03 11:22 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 16:58 ` Andy Shevchenko
2020-04-08 22:15 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 11/29] x86: apl: Add Global NVS table header Simon Glass
2020-03-31 8:07 ` Antwort: " Wolfgang Wallner
2020-04-03 11:25 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 12/29] dm: core: Add basic ACPI support Simon Glass
2020-03-31 8:16 ` Antwort: " Wolfgang Wallner
2020-04-03 11:35 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 17:01 ` Andy Shevchenko
2020-04-08 22:15 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 13/29] dts: Add a binding for hid-over-i2c Simon Glass
2020-03-31 19:25 ` Antwort: " Wolfgang Wallner
2020-04-01 7:39 ` Wolfgang Wallner
2020-04-08 2:57 ` Simon Glass
2020-04-08 2:58 ` Simon Glass
2020-04-08 17:08 ` Andy Shevchenko
2020-04-08 19:39 ` Antwort: " Wolfgang Wallner
2020-04-08 20:40 ` Andy Shevchenko
2020-04-08 20:49 ` Andy Shevchenko
2020-04-15 14:00 ` Antwort: Re: " Wolfgang Wallner
2020-04-15 14:25 ` Andy Shevchenko
2020-04-15 14:57 ` Antwort: Re: Re: " Wolfgang Wallner
2020-04-15 15:15 ` Andy Shevchenko
2020-04-15 15:17 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 14/29] acpi: Add a binding for ACPI settings in the device tree Simon Glass
2020-04-03 12:42 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 15/29] acpi: Add a simple sandbox test Simon Glass
2020-04-03 12:51 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 16:57 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 16/29] x86: Move acpi_s3.h to include/acpi/ Simon Glass
2020-04-03 12:53 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 17:03 ` Andy Shevchenko [this message]
2020-03-30 23:12 ` [PATCH v3 17/29] x86: Move acpi_table header to main include/ directory Simon Glass
2020-04-03 12:58 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 17:04 ` Andy Shevchenko
2020-04-08 22:15 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 18/29] acpi: Add an __ACPI__ preprocessor symbol Simon Glass
2020-03-30 23:12 ` [PATCH v3 19/29] acpi: Add a central location for table version numbers Simon Glass
2020-03-31 19:30 ` Antwort: " Wolfgang Wallner
2020-04-08 2:58 ` Simon Glass
2020-04-03 13:04 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 20/29] acpi: Add support for DMAR Simon Glass
2020-03-31 19:34 ` Antwort: " Wolfgang Wallner
2020-04-03 13:15 ` Andy Shevchenko
2020-03-30 23:12 ` [PATCH v3 21/29] test: Add hexdump.h to the unit test header Simon Glass
2020-04-06 11:53 ` Antwort: " Wolfgang Wallner
2020-03-30 23:12 ` [PATCH v3 22/29] acpi: Add a method to write tables for a device Simon Glass
2020-04-03 13:20 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-03-30 23:12 ` [PATCH v3 23/29] acpi: Convert part of acpi_table to use acpi_ctx Simon Glass
2020-04-03 13:24 ` Andy Shevchenko
2020-04-03 13:25 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-03-30 23:13 ` [PATCH v3 24/29] x86: Allow devices to write ACPI tables Simon Glass
2020-03-30 23:13 ` [PATCH v3 25/29] acpi: Drop code for missing XSDT from acpi_write_rsdp() Simon Glass
2020-03-30 23:13 ` [PATCH v3 26/29] acpi: Move acpi_add_table() to generic code Simon Glass
2020-03-30 23:13 ` [PATCH v3 27/29] acpi: Put table-setup code in its own function Simon Glass
2020-04-03 13:32 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-04-08 17:11 ` Andy Shevchenko
2020-04-08 19:35 ` Simon Glass
2020-03-30 23:13 ` [PATCH v3 28/29] acpi: Move the xsdt pointer to acpi_ctx Simon Glass
2020-03-30 23:13 ` [PATCH v3 29/29] acpi: Add an acpi command Simon Glass
2020-03-31 18:14 ` Leif Lindholm
2020-04-03 13:41 ` Andy Shevchenko
2020-04-03 13:39 ` Andy Shevchenko
2020-03-31 6:31 ` [PATCH v3 00/29] dm: Add programmatic generation of ACPI tables (part A) Heinrich Schuchardt
2020-04-02 2:34 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408170320.GL3676135@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox