From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 8 Apr 2020 20:03:20 +0300
Subject: [PATCH v3 16/29] x86: Move acpi_s3.h to include/acpi/
In-Reply-To: <CAPnjgZ0nyK-hWwbyKUyYeuzUVGAi0+OvON4JkPR-s-xzN-ynWw@mail.gmail.com>
References: <20200330231305.130488-1-sjg@chromium.org>
 <20200330171226.v3.16.Ie511d0d0f8ddd84e9c49768b0b68f7bedd402428@changeid>
 <20200403125355.GC3676135@smile.fi.intel.com>
 <CAPnjgZ0nyK-hWwbyKUyYeuzUVGAi0+OvON4JkPR-s-xzN-ynWw@mail.gmail.com>
Message-ID: <20200408170320.GL3676135@smile.fi.intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, Apr 07, 2020 at 08:57:25PM -0600, Simon Glass wrote:
> On Fri, 3 Apr 2020 at 06:53, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Mar 30, 2020 at 05:12:52PM -0600, Simon Glass wrote:
> > > This header relates to ACPI and we are about to add some more ACPI
> > > headers. Move this one into a new directory so they are together.
> > >
> >
> > FWIW,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > One nit below.

> > > -#ifdef CONFIG_X86
> >
> > There is nothing in commit message about this change. Is it safe? Don't you get
> > new compiler warnings (like defined-but-not-used)?
> 
> Not that I can see. Since it isn't specific to x86 anymore it seems
> like a good idea to remove this #ifdef

Please mention in commit message.

-- 
With Best Regards,
Andy Shevchenko