From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Wed, 8 Apr 2020 20:14:32 +0300 Subject: [PATCH v4 13/31] x86: apl: Add Global NVS table header In-Reply-To: <20200407210023.v4.13.I4aa2fe09882dcf5a040603469bac136e4342d350@changeid> References: <20200408030107.168474-1-sjg@chromium.org> <20200407210023.v4.13.I4aa2fe09882dcf5a040603469bac136e4342d350@changeid> Message-ID: <20200408171432.GP3676135@smile.fi.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Apr 07, 2020 at 09:00:49PM -0600, Simon Glass wrote: > Add the C version of this header. It includes a few Chrome OS bits which > are disabled for a normal build. > + u8 unused[0x100 - 0x3d]; /* Pad out to 0x100 */ > + u8 unused2[0x1000 - 0x100]; /* Pad out to 4KB */ Inconsistent size representation in the comment: 256 bytes, 4096 bytes? Also I would rather name unused1 and unused2. -- With Best Regards, Andy Shevchenko