From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Behun <marek.behun@nic.cz>
Date: Thu, 9 Apr 2020 15:29:03 +0200
Subject: [PATCH v1 u-boot-marvell 4/5] arm64: mvebu: a37xx: add
 device-tree fixer for PCIe regions
In-Reply-To: <b9e2a53c-801b-b3d1-5421-7ccb4258bac0@denx.de>
References: <20200408172522.18941-1-marek.behun@nic.cz>
 <20200408172522.18941-5-marek.behun@nic.cz>
 <b9e2a53c-801b-b3d1-5421-7ccb4258bac0@denx.de>
Message-ID: <20200409152903.5273e404@nic.cz>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefan,

sorry I overlooked the other two things you commented on the code.

On Thu, 9 Apr 2020 10:09:52 +0200
Stefan Roese <sr@denx.de> wrote:

> > +	return -1;  
> 
> 	return -ENOENT; ?

The function returns u32. The error is reported by returning (u32)-1.
The check base < 0 won't work. I would specifically have to check for
-ENOENT, or use something like ERR_PTR from Linux.

> 	if (base < 0)
> 		return base; ?