[PATCH 4/5] lib: do not provide hexdump in SPL

Tom Rini
2020-04-16T17:02:20Z

On Thu, Apr 16, 2020 at 06:27:00PM +0200, Heinrich Schuchardt wrote:
> On 4/16/20 4:32 AM, Tom Rini wrote:
> > On Wed, Apr 15, 2020 at 06:46:22PM +0200, Heinrich Schuchardt wrote:
> >
> >> SPL should not be enlarged by building with CONFIG_HEXDUMP=y.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >> ---
> >> lib/hexdump.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Does this show up as a problem somewhere? I don't see this resulting in
> > size savings anywhere, thanks.
> >
>
> I checked for origin/master pine64_defconfig
>
> with HEXDUMP
> 1493728 spl/u-boot-spl
>
> without HEXDUMP
> 1485712 spl/u-boot-spl
>
> Currently no driver is actually calling the hexdump function is SPL. So
> the code seems to be removed in the final binary.

OK, thanks.

Reviewed-by: Tom Rini <trini@konsulko.com>

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200416/5e07babe/attachment.sig>