[PATCH 5/5] dlmalloc: remove unit test support in SPL

Heinrich Schuchardt
2020-04-16T17:19:07Z

On 16.04.20 19:00, Tom Rini wrote:
> On Thu, Apr 16, 2020 at 05:37:56PM +0200, Heinrich Schuchardt
> wrote:
>> On 4/16/20 4:32 AM, Tom Rini wrote:
>>> On Wed, Apr 15, 2020 at 06:46:23PM +0200, Heinrich Schuchardt
>>> wrote:
>>>
>>>> We cannot run unit tests in SPL. So remove the unit test
>>>> support.
>>>>
>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> ---
>>>> common/dlmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1
>>>> deletion(-)
>>>
>>> Does this show up as a problem somewhere? I don't see this
>>> resulting in size savings anywhere, thanks.
>>>
>>
>> pine64-lts_defconfig + CONFIG_UNIT_TEST=y:
>>
>> without patch: 1487904 spl/u-boot-spl
>>
>> with patch: 1485712 spl/u-boot-spl
>>
>> The difference seems to be in the size of debug sections.
>
> Interesting, what toolchain are you using? That doesn't show up
> here. Thanks!
>

I am on Debian Bullseye gcc-9.2.

As you already remarked replying to another patch the linker is
stripping the differences. My idea is that we should only compile the
necessary.

Best regards

Heinrich