From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/5] lib: date functions in SPL
Date: Thu, 16 Apr 2020 13:04:15 -0400 [thread overview]
Message-ID: <20200416170415.GV12111@bill-the-cat> (raw)
In-Reply-To: <8d728917-39e1-616d-cc48-23a657c23262@gmx.de>
On Thu, Apr 16, 2020 at 06:30:48PM +0200, Heinrich Schuchardt wrote:
> On 4/16/20 4:32 AM, Tom Rini wrote:
> > On Wed, Apr 15, 2020 at 06:46:20PM +0200, Heinrich Schuchardt wrote:
> >
> >> Date functions are only needed in SPL if SPL contains RTC drivers.
> >>
> >> Fixes: 05429b6cf5b3 ("rtc: move date.c from drivers/rtc/ to lib/")
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >
> > Does this show up as a problem somewhere? I don't see this resulting in
> > size savings anywhere, thanks.
> >
>
> We are compiling ./spl/lib/date.o for no good reason since said patch.
> It may be that the when creating u-boot-spl.bin from u-boot-spl this
> gets deleted again due to linker optimization.
It is discarded at link time, yes. I'm generally dis-inclined to grab
patches like this when it adds more to the Makefile without a size
savings.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200416/952b4f4c/attachment.sig>
next prev parent reply other threads:[~2020-04-16 17:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 16:46 [PATCH 0/5] lib: reduce SPL size Heinrich Schuchardt
2020-04-15 16:46 ` [PATCH 1/5] lib: do not build OID registry in SPL Heinrich Schuchardt
2020-04-16 2:32 ` Tom Rini
2020-04-16 15:49 ` Heinrich Schuchardt
2020-04-16 17:00 ` Tom Rini
2020-04-24 17:11 ` Tom Rini
2020-04-15 16:46 ` [PATCH 2/5] lib: date functions " Heinrich Schuchardt
2020-04-16 2:32 ` Tom Rini
2020-04-16 16:30 ` Heinrich Schuchardt
2020-04-16 17:04 ` Tom Rini [this message]
2020-04-15 16:46 ` [PATCH 3/5] common: image_sign_info helper " Heinrich Schuchardt
2020-04-16 2:32 ` Tom Rini
2020-04-24 17:11 ` Tom Rini
2020-04-15 16:46 ` [PATCH 4/5] lib: do not provide hexdump " Heinrich Schuchardt
2020-04-16 2:32 ` Tom Rini
2020-04-16 16:27 ` Heinrich Schuchardt
2020-04-16 17:02 ` Tom Rini
2020-04-24 17:11 ` Tom Rini
2020-04-15 16:46 ` [PATCH 5/5] dlmalloc: remove unit test support " Heinrich Schuchardt
2020-04-16 2:32 ` Tom Rini
2020-04-16 15:37 ` Heinrich Schuchardt
2020-04-16 17:00 ` Tom Rini
2020-04-16 17:19 ` Heinrich Schuchardt
2020-04-24 17:11 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416170415.GV12111@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox