[PATCH 1/5] wandboard: Fix detection for mx6q/mx6dl revD1 revariants

Fabio Estevam
2020-04-17T00:14:34Z

Sorry for sending this twice.

The first submission had the wrong patch 3/5.

On Thu, Apr 16, 2020 at 9:10 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> The detection of the revD1 version is based on the presence of the PMIC.
>
> Currently revb1 device trees are used for mx6q/mx6dl variants, which
> do not have the PMIC nodes.
>
> This causes revD1 boards to be incorrectly be detected as revB1.
>
> Use the revd1 device trees, so that the PMIC node can be found and
> then the PMIC can be detected by reading its register ID.
>
> Reported-by: Heiko Schocher <hs@denx.de>
> Reported-by: Derek Atkins <derek@ihtfp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi Heiko,
>
> Could you please try this on your mx6dl wandboard revD1 board?
>
> I recall you reported this issue sometime ago.
>
> Derek tested this on his mx6q wandboard revD1 board and it worked
> fine.
>
> I have also tested it on a revB1 and the version is properly
> detected.
>
> Thanks
>
> arch/arm/dts/Makefile | 4 ++--
> ...{imx6dl-wandboard-revb1.dts => imx6dl-wandboard-revd1.dts} | 4 ++--
> .../{imx6q-wandboard-revb1.dts => imx6q-wandboard-revd1.dts} | 4 ++--
> configs/wandboard_defconfig | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
> rename arch/arm/dts/{imx6dl-wandboard-revb1.dts => imx6dl-wandboard-revd1.dts} (78%)
> rename arch/arm/dts/{imx6q-wandboard-revb1.dts => imx6q-wandboard-revd1.dts} (80%)
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 820ee9733a..2a71917c92 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -622,7 +622,7 @@ dtb-y += \
> imx6dl-pico.dtb \
> imx6dl-sabreauto.dtb \
> imx6dl-sabresd.dtb \
> - imx6dl-wandboard-revb1.dtb \
> + imx6dl-wandboard-revd1.dtb \
>
> endif
>
> @@ -654,7 +654,7 @@ dtb-y += \
> imx6q-sabrelite.dtb \
> imx6q-sabresd.dtb \
> imx6q-tbs2910.dtb \
> - imx6q-wandboard-revb1.dtb \
> + imx6q-wandboard-revd1.dtb \
> imx6qp-sabreauto.dtb \
> imx6qp-sabresd.dtb \
> imx6qp-wandboard-revd1.dtb \
> diff --git a/arch/arm/dts/imx6dl-wandboard-revb1.dts b/arch/arm/dts/imx6dl-wandboard-revd1.dts
> similarity index 78%
> rename from arch/arm/dts/imx6dl-wandboard-revb1.dts
> rename to arch/arm/dts/imx6dl-wandboard-revd1.dts
> index c2946fbaa0..6d1d863c2e 100644
> --- a/arch/arm/dts/imx6dl-wandboard-revb1.dts
> +++ b/arch/arm/dts/imx6dl-wandboard-revd1.dts
> @@ -6,10 +6,10 @@
> */
> /dts-v1/;
> #include "imx6dl.dtsi"
> -#include "imx6qdl-wandboard-revb1.dtsi"
> +#include "imx6qdl-wandboard-revd1.dtsi"
>
> / {
> - model = "Wandboard i.MX6 Dual Lite Board rev B1";
> + model = "Wandboard i.MX6 Dual Lite Board revD1";
> compatible = "wand,imx6dl-wandboard", "fsl,imx6dl";
>
> memory at 10000000 {
> diff --git a/arch/arm/dts/imx6q-wandboard-revb1.dts b/arch/arm/dts/imx6q-wandboard-revd1.dts
> similarity index 80%
> rename from arch/arm/dts/imx6q-wandboard-revb1.dts
> rename to arch/arm/dts/imx6q-wandboard-revd1.dts
> index f6ccbecff9..55331021d8 100644
> --- a/arch/arm/dts/imx6q-wandboard-revb1.dts
> +++ b/arch/arm/dts/imx6q-wandboard-revd1.dts
> @@ -6,10 +6,10 @@
> */
> /dts-v1/;
> #include "imx6q.dtsi"
> -#include "imx6qdl-wandboard-revb1.dtsi"
> +#include "imx6qdl-wandboard-revd1.dtsi"
>
> / {
> - model = "Wandboard i.MX6 Quad Board rev B1";
> + model = "Wandboard i.MX6 Quad Board revD1";
> compatible = "wand,imx6q-wandboard", "fsl,imx6q";
>
> memory at 10000000 {
> diff --git a/configs/wandboard_defconfig b/configs/wandboard_defconfig
> index 82e517b90f..ee70758f3a 100644
> --- a/configs/wandboard_defconfig
> +++ b/configs/wandboard_defconfig
> @@ -46,8 +46,8 @@ CONFIG_CMD_BMP=y
> CONFIG_CMD_CACHE=y
> CONFIG_CMD_EXT4_WRITE=y
> CONFIG_OF_CONTROL=y
> -CONFIG_DEFAULT_DEVICE_TREE="imx6dl-wandboard-revb1"
> -CONFIG_OF_LIST="imx6q-wandboard-revb1 imx6qp-wandboard-revd1 imx6dl-wandboard-revb1"
> +CONFIG_DEFAULT_DEVICE_TREE="imx6dl-wandboard-revd1"
> +CONFIG_OF_LIST="imx6q-wandboard-revd1 imx6qp-wandboard-revd1 imx6dl-wandboard-revd1"
> CONFIG_MULTI_DTB_FIT=y
> CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> --
> 2.17.1
>