public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 5/5] wandboard: Remove checkboard()
Date: Thu, 16 Apr 2020 21:12:31 -0300	[thread overview]
Message-ID: <20200417001231.11406-5-festevam@gmail.com> (raw)
In-Reply-To: <20200417001231.11406-1-festevam@gmail.com>

Since the variant revision is no longer show, simply get rid
of checkboard().

Move the gpio_request() prior to its usage.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 board/wandboard/wandboard.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index df454d8f17..bb1ffd87e1 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -404,6 +404,7 @@ static const struct boot_mode board_boot_modes[] = {
 static bool is_revc1(void)
 {
 	SETUP_IOMUX_PADS(rev_detection_pad);
+	gpio_request(REV_DETECTION, "REV_DETECT");
 	gpio_direction_input(REV_DETECTION);
 
 	if (gpio_get_value(REV_DETECTION))
@@ -466,20 +467,6 @@ int board_init(void)
 	return 0;
 }
 
-int checkboard(void)
-{
-	gpio_request(REV_DETECTION, "REV_DETECT");
-
-	if (is_revd1())
-		puts("Board: Wandboard rev D1\n");
-	else if (is_revc1())
-		puts("Board: Wandboard rev C1\n");
-	else
-		puts("Board: Wandboard rev B1\n");
-
-	return 0;
-}
-
 #ifdef CONFIG_SPL_LOAD_FIT
 int board_fit_config_name_match(const char *name)
 {
-- 
2.17.1

  parent reply	other threads:[~2020-04-17  0:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17  0:12 [PATCH 1/5] wandboard: Fix detection for mx6q/mx6dl revD1 revariants Fabio Estevam
2020-04-17  0:12 ` [PATCH 2/5] pmic: pfuze100: Change error message level to debug Fabio Estevam
2020-04-17  0:12 ` [PATCH 3/5] wandboard: Do not print error when PMIC is not present Fabio Estevam
2020-04-17  0:12 ` [PATCH 4/5] wandboard: Remove CONFIG_DISPLAY_BOARDINFO_LATE Fabio Estevam
2020-04-17  0:12 ` Fabio Estevam [this message]
2020-04-17  7:56 ` [PATCH 1/5] wandboard: Fix detection for mx6q/mx6dl revD1 revariants Heiko Schocher
2020-04-17 11:15   ` Fabio Estevam
2020-04-17 11:33     ` Fabio Estevam
2020-04-17 11:41       ` Fabio Estevam
2020-04-17 12:00         ` Derek Atkins
2020-04-17 12:30           ` Fabio Estevam
2020-04-17 14:50             ` Heiko Schocher
2020-04-17 15:02               ` Derek Atkins
  -- strict thread matches above, loose matches on Subject: below --
2020-04-17  0:10 Fabio Estevam
2020-04-17  0:10 ` [PATCH 5/5] wandboard: Remove checkboard() Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417001231.11406-5-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox