public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 5/5] wandboard: Print the board version in board_late_init()
Date: Fri, 17 Apr 2020 09:27:13 -0300	[thread overview]
Message-ID: <20200417122713.30574-5-festevam@gmail.com> (raw)
In-Reply-To: <20200417122713.30574-1-festevam@gmail.com>

Since CONFIG_DISPLAY_BOARDINFO_LATE is no longer used,  the checkboard()
function is no longer called.

As it is useful to print the board revision, print it inside
board_late_init() instead.

Also, to avoid GPIO errors related to using a GPIO without requesting it,
move the gpio_request(REV_DETECTION, "REV_DETECT") call prior to its
usage. 

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Still print the board revision, but on a different location now.

 board/wandboard/wandboard.c | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 7fd60682a5..fb2f3c1fd2 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -404,6 +404,7 @@ static const struct boot_mode board_boot_modes[] = {
 static bool is_revc1(void)
 {
 	SETUP_IOMUX_PADS(rev_detection_pad);
+	gpio_request(REV_DETECTION, "REV_DETECT");
 	gpio_direction_input(REV_DETECTION);
 
 	if (gpio_get_value(REV_DETECTION))
@@ -442,6 +443,14 @@ int board_late_init(void)
 		env_set("board_name", "B1");
 #endif
 	setup_iomux_enet();
+
+	if (is_revd1())
+		puts("Board: Wandboard rev D1\n");
+	else if (is_revc1())
+		puts("Board: Wandboard rev C1\n");
+	else
+		puts("Board: Wandboard rev B1\n");
+
 	return 0;
 }
 
@@ -466,20 +475,6 @@ int board_init(void)
 	return 0;
 }
 
-int checkboard(void)
-{
-	gpio_request(REV_DETECTION, "REV_DETECT");
-
-	if (is_revd1())
-		puts("Board: Wandboard rev D1\n");
-	else if (is_revc1())
-		puts("Board: Wandboard rev C1\n");
-	else
-		puts("Board: Wandboard rev B1\n");
-
-	return 0;
-}
-
 #ifdef CONFIG_SPL_LOAD_FIT
 int board_fit_config_name_match(const char *name)
 {
-- 
2.17.1

  parent reply	other threads:[~2020-04-17 12:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 12:27 [PATCH v2 1/5] wandboard: Fix version detection for mx6q/mx6dl revD1 Fabio Estevam
2020-04-17 12:27 ` [PATCH v2 2/5] pmic: pfuze100: Change error message level to debug Fabio Estevam
2020-04-17 14:51   ` Heiko Schocher
2020-04-19  9:08   ` sbabic at denx.de
2020-04-17 12:27 ` [PATCH v2 3/5] wandboard: Do not print error when PMIC is not present Fabio Estevam
2020-04-17 14:51   ` Heiko Schocher
2020-04-19  9:09   ` sbabic at denx.de
2020-04-17 12:27 ` [PATCH v2 4/5] wandboard: Remove CONFIG_DISPLAY_BOARDINFO_LATE Fabio Estevam
2020-04-17 14:51   ` Heiko Schocher
2020-04-19  9:09   ` sbabic at denx.de
2020-04-17 12:27 ` Fabio Estevam [this message]
2020-04-17 14:52   ` [PATCH v2 5/5] wandboard: Print the board version in board_late_init() Heiko Schocher
2020-04-19  9:09   ` sbabic at denx.de
2020-04-17 14:51 ` [PATCH v2 1/5] wandboard: Fix version detection for mx6q/mx6dl revD1 Heiko Schocher
2020-04-17 16:09 ` Peter Robinson
2020-04-19  9:08 ` sbabic at denx.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417122713.30574-5-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox