From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Behun Date: Mon, 20 Apr 2020 11:27:46 +0200 Subject: [PATCH u-boot-marvell 04/11] usb: host: make PHY handling more generic In-Reply-To: <72962066-60ff-71e7-4e54-a2b57399ae6a@denx.de> References: <20200419154850.25868-1-marek.behun@nic.cz> <20200419154850.25868-5-marek.behun@nic.cz> <72962066-60ff-71e7-4e54-a2b57399ae6a@denx.de> Message-ID: <20200420112746.528a4978@nic.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 20 Apr 2020 03:41:49 +0200 Marek Vasut wrote: > > + ret = generic_phy_set_mode(&phy, PHY_MODE_USB_HOST_SS, 0); > > How can this ever work with EHCI , which is HS/FS/LS , but not SS ? > Marek, this is how kernel does it in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/core/hcd.c#n2628 First PHY_MODE_USB_HOST_SS is tried, then PHY_MODE_USB_HOST.