From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 21 Apr 2020 08:25:40 -0400 Subject: [PATCH] env: make file-scope env_ptr variables static In-Reply-To: <20200218085356.13929-1-rasmus.villemoes@prevas.dk> References: <20200218085356.13929-1-rasmus.villemoes@prevas.dk> Message-ID: <20200421122540.GS4555@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Feb 18, 2020 at 08:54:09AM +0000, Rasmus Villemoes wrote: > The combination ENV_IS_IN_NVRAM=y, ENV_IS_IN_REMOTE=y fails to build: > > env/remote.o:/mnt/ext4/devel/u-boot/env/remote.c:17: multiple definition of `env_ptr' > env/nvram.o:/mnt/ext4/devel/u-boot/env/nvram.c:41: first defined here > > It's not necessarily a meaningful combination, but for build-testing > it's nice to be able to enable most ENV_IS_IN_* at the same time, and > since these env_ptr are not declared anywhere, they really have no > reason to have external linkage. > > nand.c and flash.c similarly already define file-scope static env_ptr > variables. > > Signed-off-by: Rasmus Villemoes Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: