From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 2/7] uart: pl011: Add proper DM clock support
Date: Fri, 24 Apr 2020 10:51:11 -0400 [thread overview]
Message-ID: <20200424145111.GA8352@bill-the-cat> (raw)
In-Reply-To: <20200407111236.14930-3-andre.przywara@arm.com>
On Tue, Apr 07, 2020 at 12:12:31PM +0100, Andre Przywara wrote:
> Even though the PL011 UART driver claims to be DM compliant, it does not
> really a good job with parsing DT nodes. U-Boot seems to adhere to a
> non-standard binding, either requiring to have a "skip-init" property in
> the node, or to have an extra "clock" property holding the base
> *frequency* value for the baud rate generator.
> DTs in the U-Boot tree seem to have been hacked to match this
> requirement.
>
> The official binding does not mention any of these properties, instead
> recommends a standard "clocks" property to point to the baud base clock.
>
> Some boards use simple "fixed-clock" providers, which U-Boot readily
> supports, so let's add some simple DM clock code to the PL011 driver to
> learn the rate of the first clock, as described by the official binding.
>
> These clock nodes seem to be not ready very early in the boot process,
> so provide a fallback value, by re-using the already existing
> CONFIG_PL011_CLOCK variable.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
This patch breaks rpi_3*/rpi_4/rpi_arm64, please fix, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200424/01280c9f/attachment.sig>
next prev parent reply other threads:[~2020-04-24 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 11:12 [PATCH v2 0/7] Arm Juno board OF_CONTROL upgrade Andre Przywara
2020-04-07 11:12 ` [PATCH v2 1/7] arm: juno: Fix Juno address variables Andre Przywara
2020-04-07 11:12 ` [PATCH v2 2/7] uart: pl011: Add proper DM clock support Andre Przywara
2020-04-24 14:51 ` Tom Rini [this message]
2020-04-27 12:21 ` André Przywara
2020-04-07 11:12 ` [PATCH v2 3/7] arm: juno: Fix UART clock rate Andre Przywara
2020-04-07 11:12 ` [PATCH v2 4/7] arm: juno: Enable OF_CONTROL Andre Przywara
2020-04-07 11:12 ` [PATCH v2 5/7] arm: juno: Use PSCI based reset Andre Przywara
2020-04-07 11:12 ` [PATCH v2 6/7] arm: juno: enable USB Andre Przywara
2020-04-07 11:12 ` [PATCH v2 7/7] arm: vexpress64: Remove unneeded CONFIG_ check Andre Przywara
2020-04-12 20:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424145111.GA8352@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox