From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 24 Apr 2020 13:08:29 -0400 Subject: [PATCH 4/5] env/ext4.c: remove CONFIG_CMD_SAVEENV ifdef In-Reply-To: <20200219094726.26798-5-rasmus.villemoes@prevas.dk> References: <20200219094726.26798-1-rasmus.villemoes@prevas.dk> <20200219094726.26798-5-rasmus.villemoes@prevas.dk> Message-ID: <20200424170829.GX4555@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 19, 2020 at 09:47:42AM +0000, Rasmus Villemoes wrote: > Removing this ifdef/endif pair yields a "defined but unused warning" > for CONFIG_CMD_SAVEENV=n, but that vanishes if we use the ENV_SAVE_PTR > macro instead. This gives slightly better compile testing, and > moreover, it's possible to have > > CONFIG_CMD_SAVEENV=n > CONFIG_SPL_SAVEENV=y > SPL_ENV_IS_IN_EXT4=y > > in which case env_ext4_save would erroneously not be compiled in. > > Signed-off-by: Rasmus Villemoes Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: