From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 24 Apr 2020 13:08:35 -0400 Subject: [PATCH 5/5] env/sf.c: drop private CMD_SAVEENV logic In-Reply-To: <20200219094726.26798-6-rasmus.villemoes@prevas.dk> References: <20200219094726.26798-1-rasmus.villemoes@prevas.dk> <20200219094726.26798-6-rasmus.villemoes@prevas.dk> Message-ID: <20200424170835.GY4555@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 19, 2020 at 09:47:43AM +0000, Rasmus Villemoes wrote: > Deciding whether to compile the env_sf_save() function based solely on > CONFIG_SPL_BUILD is wrong: For U-Boot proper, it leads to a build > warning in case CONFIG_CMD_SAVEENV=n (because the env_save_ptr() macro > causes the function to indeed not be referenced anywhere). And for > SPL, when one selects CONFIG_SPL_SAVEENV, one obviously expects to > actually be able to save the environment. > > Signed-off-by: Rasmus Villemoes Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: