public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] sunxi: Fix PHY regression on A20-OLinuXino-Lime2 and A20-Olimex-SOM-EVB
Date: Fri, 24 Apr 2020 19:09:56 +0200	[thread overview]
Message-ID: <20200424190956.65b666fa@crub> (raw)
In-Reply-To: <20200424163405.16916-1-trini@konsulko.com>

On Fri, 24 Apr 2020 12:34:05 -0400
Tom Rini trini at konsulko.com wrote:

> When moving the PHYLIB PHY drivers around in Kconfig we did not at the
> same time perform a careful migration of the related drivers and
> sub-options.  This lead to the case where previously Kconfig-enabled
> driver choices were now disabled on some platforms.  Correct this by
> enabling both the PHY driver and sub-option on the above referenced
> platforms.
> 
> Fixes: af2cbfd6b982 ("drivers: net: Provide Kconfig menu for PHYLIB")
> Fixes: 8728c97eff5b ("configs: Re-sync")
> Reported-by: Dario <dario86@tutamail.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> After checking back on the original commit I can see that these are the
> only two platforms to have been broken in the change.

configs/A20-OLinuXino-Lime2-eMMC_defconfig might need similar change.

We get many build warnings like:
include/configs/sunxi-common.h:276:0: warning: "CONFIG_PHY_REALTEK" redefined

Could you include following change to fix it?

diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index 0ef289fd64..f4bbce8443 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -273,8 +273,10 @@ extern int soft_i2c_gpio_scl;
 /* Ethernet support */
 
 #ifdef CONFIG_SUN7I_GMAC
+#ifndef CONFIG_PHY_REALTEK
 #define CONFIG_PHY_REALTEK
 #endif
+#endif
 
 #ifdef CONFIG_USB_EHCI_HCD
 #define CONFIG_USB_OHCI_NEW

Thanks!
Anatolij

  reply	other threads:[~2020-04-24 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 16:34 [PATCH] sunxi: Fix PHY regression on A20-OLinuXino-Lime2 and A20-Olimex-SOM-EVB Tom Rini
2020-04-24 17:09 ` Anatolij Gustschin [this message]
2020-04-24 17:14   ` Tom Rini
2020-04-29 12:49 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424190956.65b666fa@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox