[PATCH 5/8] pci: Add Rockchip PCIe controller driver

Robin Murphy
2020-04-27T17:19:37Z

On 2020-04-25 8:36 pm, Jagan Teki wrote:
> On Sun, Apr 26, 2020 at 12:23 AM Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>>
>>> From: Jagan Teki <jagan@amarulasolutions.com>
>>> Date: Sat, 25 Apr 2020 16:33:51 +0530
>>>
>>> Add Rockchip PCIe controller driver for rk3399 platform.
>>>
>>> Driver support Gen1 by operating as a Root complex.
>>>
>>> Thanks to Patrick for initial work.
>>
>> Tried to get this to work on my firefly-rk3399 which made me notice
>> some shortcomings:
>>
>> 1. The vpcie1v8 and vpcie0v9 supplies are optional, just like the
>> vpcie3v3 supply.

FWIW those are "non-optional" in Linux in the sense that supplies to the
PCIE_AVDD_0V9 and PCIE_AVDD_1V8 pins of the SoC must physically exist,
even if they aren't described. If U-Boot doesn't have the same "create a
dummy regulator if none is specified" behaviour then you might need some
slightly different logic there.

The 3.3V and 12V supplies on the other hand may legitimately not be part
of the board at all, depending on whether it implements a full-size
slot, a mini-PCI/M.2 socket, a hard-wired endpoint chip, or just the
data and clock signal pairs exposed on some non-standard connector.

Robin.