From: Chen-Yu Tsai <wens@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH v3 9/9] rockchip: dts: rock64: Fix XHCI usage
Date: Mon, 27 Apr 2020 14:52:54 +0800 [thread overview]
Message-ID: <20200427065254.15397-10-wens@kernel.org> (raw)
In-Reply-To: <20200427065254.15397-1-wens@kernel.org>
From: Chen-Yu Tsai <wens@csie.org>
If the VBUS regulator is always-on, XHCI will fail to detect USB 3.0
devices; USB 2.0 devices will work however.
Make the VBUS regulator controllable and tie it to only the XHCI. This
makes all three USB ports usable.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Changes since v2:
- new patch
---
arch/arm/dts/rk3328-rock64-u-boot.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/dts/rk3328-rock64-u-boot.dtsi b/arch/arm/dts/rk3328-rock64-u-boot.dtsi
index e5946d2d2dc7..8318bf4e6030 100644
--- a/arch/arm/dts/rk3328-rock64-u-boot.dtsi
+++ b/arch/arm/dts/rk3328-rock64-u-boot.dtsi
@@ -12,5 +12,16 @@
};
&usb_host0_xhci {
+ vbus-supply = <&vcc_host_5v>;
status = "okay";
};
+
+/*
+ * This makes XHCI responsible for toggling VBUS. This is needed to work
+ * around an issue where either XHCI only works with USB 2.0 or OTG doesn't
+ * work, depending on how VBUS is configured. Having USB 3.0 seems better.
+ */
+&vcc_host_5v {
+ /delete-property/ regulator-always-on;
+ /delete-property/ regulator-boot-on;
+};
--
2.26.0
next prev parent reply other threads:[~2020-04-27 6:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 6:52 [PATCH v3 0/9] rockchip: rk3328: sync dts and add ROC-RK3328-CC board Chen-Yu Tsai
2020-04-27 6:52 ` [PATCH v3 1/9] rockchip: dts: rk3328-evb: Move vcc5v0-host-xhci-drv to -u-boot.dtsi Chen-Yu Tsai
2020-04-27 6:52 ` [PATCH v3 2/9] rockchip: dts: rk3328-evb: Move gmac2io related nodes " Chen-Yu Tsai
2020-04-27 6:52 ` [PATCH v3 3/9] rockchip: dts: rk3328: Move OTG node's hnp-srp-disable to rk3328-u-boot.dtsi Chen-Yu Tsai
2020-04-28 14:23 ` Kever Yang
2020-04-27 6:52 ` [PATCH v3 4/9] dt-bindings: clock: rk3328: sync from upstream Linux kernel Chen-Yu Tsai
2020-04-27 6:52 ` [PATCH v3 5/9] dt-bindings: power: rk3328-power: " Chen-Yu Tsai
2020-04-27 6:52 ` [PATCH v3 6/9] rockchip: rk3328: Disable generic PHY support Chen-Yu Tsai
2020-04-28 14:24 ` Kever Yang
2020-04-27 6:52 ` [PATCH v3 7/9] rockchip: dts: rk3328: Sync device tree files from Linux Chen-Yu Tsai
2020-05-11 18:59 ` Kurt Miller
2020-05-14 4:10 ` Chen-Yu Tsai
2020-05-14 17:02 ` Kurt Miller
2020-04-27 6:52 ` [PATCH v3 8/9] rockchip: rk3328: Add support for ROC-RK3328-CC board Chen-Yu Tsai
2020-04-28 14:25 ` Kever Yang
2020-04-30 9:08 ` Kever Yang
2020-04-30 9:16 ` Chen-Yu Tsai
2020-04-27 6:52 ` Chen-Yu Tsai [this message]
2020-04-28 14:26 ` [PATCH v3 9/9] rockchip: dts: rock64: Fix XHCI usage Kever Yang
2020-04-30 9:04 ` [PATCH v3 0/9] rockchip: rk3328: sync dts and add ROC-RK3328-CC board Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427065254.15397-10-wens@kernel.org \
--to=wens@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox