public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 3/4] video: mxsfb: add clk_enable()
Date: Mon, 27 Apr 2020 17:53:05 +0200	[thread overview]
Message-ID: <20200427155306.105284-4-giulio.benetti@benettiengineering.com> (raw)
In-Reply-To: <20200427155306.105284-1-giulio.benetti@benettiengineering.com>

BROM doesn't enable lcdif by default so add clk_enable() after
clk_set_rate().

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* call clk_enable() after clk_set_rate() as suggested by Fabio
---
 drivers/video/mxsfb.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 8a5a61c9fb..12d00b4689 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -77,6 +77,12 @@ static void mxs_lcd_init(struct udevice *dev, u32 fb_addr,
 		dev_err(dev, "Failed to set mxs clk: %d\n", ret);
 		return;
 	}
+
+	ret = clk_enable(&per_clk);
+	if (ret < 0) {
+		dev_err(dev, "Failed to enable mxs clk: %d\n", ret);
+		return;
+	}
 #else
 	/* Kick in the LCDIF clock */
 	mxs_set_lcdclk(MXS_LCDIF_BASE, timings->pixelclock.typ / 1000);
-- 
2.20.1

  parent reply	other threads:[~2020-04-27 15:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 15:53 [PATCH v3 0/4] Various i.MXRT bug/typo fixes Giulio Benetti
2020-04-27 15:53 ` [PATCH v3 1/4] imxrt1050-evk: README: change dd command destination Giulio Benetti
2020-05-02  9:08   ` sbabic at denx.de
2020-04-27 15:53 ` [PATCH v3 2/4] imxrt1020-evk: " Giulio Benetti
2020-05-02  9:08   ` sbabic at denx.de
2020-04-27 15:53 ` Giulio Benetti [this message]
2020-04-27 15:56   ` [PATCH v3 3/4] video: mxsfb: add clk_enable() Giulio Benetti
2020-05-02  9:08   ` sbabic at denx.de
2020-04-27 15:53 ` [PATCH v3 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate Giulio Benetti
2020-04-27 15:56   ` Giulio Benetti
2020-05-02  9:08   ` sbabic at denx.de
2020-04-27 15:57 ` [PATCH v3 0/4] Various i.MXRT bug/typo fixes Fabio Estevam
2020-04-27 15:57   ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427155306.105284-4-giulio.benetti@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox