From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 1/8] iopoll: Add dealy to read poll
Date: Thu, 30 Apr 2020 12:34:05 +0530 [thread overview]
Message-ID: <20200430070412.12499-2-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20200430070412.12499-1-jagan@amarulasolutions.com>
Some drivers and other bsp code not only poll the
register with timeout but also required to delay
on each transaction.
This patch add that requirement by adding sleep_us
variable so-that read_poll_timeout now support
delay as well.
Cc: Tom Rini <trini@konsulko.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- none
include/linux/iopoll.h | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/include/linux/iopoll.h b/include/linux/iopoll.h
index ab0ae1969a..0bbd757939 100644
--- a/include/linux/iopoll.h
+++ b/include/linux/iopoll.h
@@ -16,6 +16,7 @@
* @addr: Address to poll
* @val: Variable to read the value into
* @cond: Break condition (usually involving @val)
+ * @sleep_us: Maximum time to sleep in us
* @timeout_us: Timeout in us, 0 means never timeout
*
* Returns 0 on success and -ETIMEDOUT upon a timeout. In either
@@ -24,7 +25,7 @@
* When available, you'll probably want to use one of the specialized
* macros defined below rather than this macro directly.
*/
-#define readx_poll_timeout(op, addr, val, cond, timeout_us) \
+#define readx_poll_timeout(op, addr, val, cond, sleep_us, timeout_us) \
({ \
unsigned long timeout = timer_get_us() + timeout_us; \
for (;;) { \
@@ -35,33 +36,34 @@
(val) = op(addr); \
break; \
} \
+ if (sleep_us) \
+ udelay(sleep_us); \
} \
(cond) ? 0 : -ETIMEDOUT; \
})
-
#define readb_poll_timeout(addr, val, cond, timeout_us) \
- readx_poll_timeout(readb, addr, val, cond, timeout_us)
+ readx_poll_timeout(readb, addr, val, cond, false, timeout_us)
#define readw_poll_timeout(addr, val, cond, timeout_us) \
- readx_poll_timeout(readw, addr, val, cond, timeout_us)
+ readx_poll_timeout(readw, addr, val, cond, false, timeout_us)
#define readl_poll_timeout(addr, val, cond, timeout_us) \
- readx_poll_timeout(readl, addr, val, cond, timeout_us)
+ readx_poll_timeout(readl, addr, val, cond, false, timeout_us)
#define readq_poll_timeout(addr, val, cond, timeout_us) \
- readx_poll_timeout(readq, addr, val, cond, timeout_us)
+ readx_poll_timeout(readq, addr, val, cond, false, timeout_us)
#define readb_relaxed_poll_timeout(addr, val, cond, timeout_us) \
- readx_poll_timeout(readb_relaxed, addr, val, cond, timeout_us)
+ readx_poll_timeout(readb_relaxed, addr, val, cond, false, timeout_us)
#define readw_relaxed_poll_timeout(addr, val, cond, timeout_us) \
- readx_poll_timeout(readw_relaxed, addr, val, cond, timeout_us)
+ readx_poll_timeout(readw_relaxed, addr, val, cond, false, timeout_us)
#define readl_relaxed_poll_timeout(addr, val, cond, timeout_us) \
- readx_poll_timeout(readl_relaxed, addr, val, cond, timeout_us)
+ readx_poll_timeout(readl_relaxed, addr, val, cond, false, timeout_us)
#define readq_relaxed_poll_timeout(addr, val, cond, timeout_us) \
- readx_poll_timeout(readq_relaxed, addr, val, cond, timeout_us)
+ readx_poll_timeout(readq_relaxed, addr, val, cond, false, timeout_us)
#endif /* _LINUX_IOPOLL_H */
--
2.17.1
next prev parent reply other threads:[~2020-04-30 7:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 7:04 [PATCH v2 0/8] rockchip: Add PCIe host support Jagan Teki
2020-04-30 7:04 ` Jagan Teki [this message]
2020-04-30 14:46 ` [PATCH v2 1/8] iopoll: Add dealy to read poll Tom Rini
2020-04-30 21:03 ` Jagan Teki
2020-04-30 22:06 ` Tom Rini
2020-05-01 14:52 ` Jagan Teki
2020-04-30 7:04 ` [PATCH v2 2/8] iopoll: Add readl_poll_sleep_timeout Jagan Teki
2020-04-30 7:04 ` [PATCH v2 3/8] clk: rk3399: Add enable/disable clks Jagan Teki
2020-04-30 7:04 ` [PATCH v2 4/8] clk: rk3399: Enable/Disable the PCIEPHY clk Jagan Teki
2020-04-30 7:04 ` [PATCH v2 5/8] pci: Add Rockchip PCIe controller driver Jagan Teki
2020-04-30 7:04 ` [PATCH v2 6/8] pci: Add Rockchip PCIe PHY " Jagan Teki
2020-04-30 7:04 ` [PATCH v2 7/8] rockchip: Enable PCIe/M.2 on rk3399 board w/ M.2 Jagan Teki
2020-04-30 7:04 ` [PATCH v2 8/8] rockchip: Enable PCIe/M.2 on rock960 board Jagan Teki
2020-05-03 13:39 ` Manivannan Sadhasivam
2020-05-09 16:46 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430070412.12499-2-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox