From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 1 May 2020 17:56:55 -0400 Subject: [PATCH 1/2] tools/mkimage: fix handling long filenames In-Reply-To: <20200427000839.26473-2-devel-sven@geroedel.de> References: <20200427000839.26473-1-devel-sven@geroedel.de> <20200427000839.26473-2-devel-sven@geroedel.de> Message-ID: <20200501215655.GS12564@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Apr 27, 2020 at 02:08:38AM +0200, Sven Roederer wrote: > The cmdline for calling the dtc was cut-off when using long filenames (e.g. > 245 bytes) for output-file and datafile of "-f" parameter. > For FIT-images cmd[MKIMAGE_MAX_DTC_CMDLINE_LEN] is declared (hardcoded 512 bytes), > and contains some static values, the path of a tmpfile and a datafile. tmpfile is > max MKIMAGE_MAX_TMPFILE_LEN (256) and datafile might be also this size. Having two > very long pathname results in a truncation os the executed shell command, as the > truncated datafile path will not be found. > Redefine MKIMAGE_MAX_DTC_CMDLINE_LEN to "2 * MKIMAGE_MAX_TMPFILE_LEN + 35 for the > parameters. > This likely applies to the "-d" parameter, too. > > Signed-off-by: Sven Roederer Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: