From: Dan Murphy <dmurphy@ti.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 3/5] net: phy: Add helper routines to set and clear bits
Date: Mon, 4 May 2020 16:14:38 -0500 [thread overview]
Message-ID: <20200504211440.13385-4-dmurphy@ti.com> (raw)
In-Reply-To: <20200504211440.13385-1-dmurphy@ti.com>
Add phy_set/clear_bit helper routines so that ported drivers from the
kernel can use these functions.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
include/phy.h | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/include/phy.h b/include/phy.h
index 34c2af719b67..fedd14609192 100644
--- a/include/phy.h
+++ b/include/phy.h
@@ -296,6 +296,60 @@ static inline int phy_write_mmd(struct phy_device *phydev, int devad,
return phy_write(phydev, MDIO_DEVAD_NONE, MII_MMD_DATA, val);
}
+/**
+ * phy_set_bits_mmd - Convenience function for setting bits in a register
+ * on MMD
+ * @phydev: the phy_device struct
+ * @devad: the MMD containing register to modify
+ * @regnum: register number to modify
+ * @val: bits to set
+ * @return: 0 for success or negative errno for failure
+ */
+static inline int phy_set_bits_mmd(struct phy_device *phydev, int devad,
+ u32 regnum, u16 val)
+{
+ int value, ret;
+
+ value = phy_read_mmd(phydev, devad, regnum);
+ if (value < 0)
+ return value;
+
+ value |= val;
+
+ ret = phy_write_mmd(phydev, devad, regnum, value);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+}
+
+/**
+ * phy_clear_bits_mmd - Convenience function for clearing bits in a register
+ * on MMD
+ * @phydev: the phy_device struct
+ * @devad: the MMD containing register to modify
+ * @regnum: register number to modify
+ * @val: bits to clear
+ * @return: 0 for success or negative errno for failure
+ */
+static inline int phy_clear_bits_mmd(struct phy_device *phydev, int devad,
+ u32 regnum, u16 val)
+{
+ int value, ret;
+
+ value = phy_read_mmd(phydev, devad, regnum);
+ if (value < 0)
+ return value;
+
+ value &= ~val;
+
+ ret = phy_write_mmd(phydev, devad, regnum, value);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+}
+
#ifdef CONFIG_PHYLIB_10G
extern struct phy_driver gen10g_driver;
--
2.25.1
next prev parent reply other threads:[~2020-05-04 21:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 21:14 [PATCH v4 0/5] TI Ethernet PHY changes Dan Murphy
2020-05-04 21:14 ` [PATCH v4 1/5] net: phy: Add missing kernel doc to phy functions Dan Murphy
2020-06-12 21:15 ` Tom Rini
2020-05-04 21:14 ` [PATCH v4 2/5] net: phy: Fix kernel doc issues in phy.h Dan Murphy
2020-06-12 21:16 ` Tom Rini
2020-05-04 21:14 ` Dan Murphy [this message]
2020-06-12 21:16 ` [PATCH v4 3/5] net: phy: Add helper routines to set and clear bits Tom Rini
2020-05-04 21:14 ` [PATCH v4 4/5] net: phy: Add support for TI PHY init Dan Murphy
2020-06-12 21:16 ` Tom Rini
2020-05-04 21:14 ` [PATCH v4 5/5] net: phy: Add DP8382x phy registration to " Dan Murphy
2020-06-12 21:16 ` Tom Rini
2020-05-12 0:52 ` [PATCH v4 0/5] TI Ethernet PHY changes Dan Murphy
2020-06-01 18:58 ` Dan Murphy
2020-05-18 18:20 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504211440.13385-4-dmurphy@ti.com \
--to=dmurphy@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox