From: Patrick Wildt <patrick@blueri.se>
To: u-boot@lists.denx.de
Subject: TPM: remove duplicate definitions
Date: Thu, 7 May 2020 00:58:52 +0200 [thread overview]
Message-ID: <20200506225852.GA6104@nox.fritz.box> (raw)
With the recent change to tpm-v2.h, some enums are now defined twice
and tpm2_tis_spi.c fails to build. Unfortunately I fear removing
the defines from tpm_tis.h, like in this diff, will break the TPMv1
drivers tpm_tis_infineon.c and pm_tis_st33zp24_i2c.c, which depend
on those defines. Maybe they should be added to tpm-v1.h as well?
Or maybe they should be moved from tpm-v2.h to tpm_tis.h? I have
no solution.
Signed-off-by: Patrick Wildt <patrick@blueri.se>
diff --git a/drivers/tpm/tpm_tis.h b/drivers/tpm/tpm_tis.h
index 947585f8e3..4043f1aeaf 100644
--- a/drivers/tpm/tpm_tis.h
+++ b/drivers/tpm/tpm_tis.h
@@ -113,19 +113,4 @@ struct tpm_cmd_t {
*/
#define MAX_COUNT_LONG 50
-enum tis_access {
- TPM_ACCESS_VALID = 0x80,
- TPM_ACCESS_ACTIVE_LOCALITY = 0x20,
- TPM_ACCESS_REQUEST_PENDING = 0x04,
- TPM_ACCESS_REQUEST_USE = 0x02,
-};
-
-enum tis_status {
- TPM_STS_VALID = 0x80,
- TPM_STS_COMMAND_READY = 0x40,
- TPM_STS_GO = 0x20,
- TPM_STS_DATA_AVAIL = 0x10,
- TPM_STS_DATA_EXPECT = 0x08,
-};
-
#endif
next reply other threads:[~2020-05-06 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 22:58 Patrick Wildt [this message]
2020-05-10 23:31 ` TPM: remove duplicate definitions Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506225852.GA6104@nox.fritz.box \
--to=patrick@blueri.se \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox