From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 7 May 2020 09:04:20 -0400 Subject: [PATCH v2] cmd: cache: Fix non-cached memory cachability In-Reply-To: <20200428093804.20773-1-patrice.chotard@st.com> References: <20200428093804.20773-1-patrice.chotard@st.com> Message-ID: <20200507130420.GD12564@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Apr 28, 2020 at 11:38:03AM +0200, Patrice Chotard wrote: > If dcache is switched OFF to ON state and if non-cached memory is > used, this non-cached memory must be re-declared as uncached to mmu > each time dcache is set ON. > > Introduce noncached_set_region() to set this non-cached region's mmu > settings. Let architecture override it by defining it as a weak > function. > > For ARM architecture, noncached_set_region() defines all noncached > region as non-cacheable. > > Issue found on STM32MP1 platform using dwc_eth_qos ethernet driver, > when going from dcache OFF to dcache ON state, ethernet driver issued > TX timeout errors when performing dhcp or ping. > > It can be reproduced with the following sequence: > > dhcp > while true ; do > ping 192.168.1.300 ; > dcache off ; > ping 192.168.1.300 ; > dcache on ; > done > > Signed-off-by: Patrice Chotard > Cc: Marek Vasut > Cc: Joe Hershberger > Cc: Ramon Fried > Cc: Stephen Warren > Reviewed-by: Marek Vasut Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: