From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 00/22] common: Further reduce the size of common.h
Date: Fri, 8 May 2020 14:36:59 -0400 [thread overview]
Message-ID: <20200508183659.GP12564@bill-the-cat> (raw)
In-Reply-To: <20200409201506.133129-1-sjg@chromium.org>
On Thu, Apr 09, 2020 at 02:14:44PM -0600, Simon Glass wrote:
> This is yet another series to remove the contents of common.h so that
> individual files include the headers they need.
>
> With this series there are only 14 includes left.
>
> In order to get this far the commits include a number of small clean-ups:
>
> - Fixing code style like 'udelay (2)' to 'udelay(1)
> - Dropping typedefs so that forward struct declarations can be used
> - Actually adding common.h in a few files where it is missing (thus
> causing inconsistent blk.h config in EFI, for example)
>
> Unfortunately removing a header from common.h does not always just affect
> the files that rely on that header. For example, removing net.h from
> common.h created problems since net.h itself includes a lots of headers.
> Rather than blindly add net.h to each of those files, I chose to add what
> those files actually needed.
>
> Changes in v2:
> - Split out code-style changes for flash functions into a new patch
> - Split out code-style changes for log functions into a new patch
> - Split out code-style changes for time functions into a new patch
> - Add new patch to fix occurances of __ASSEMBLER__
>
> Simon Glass (22):
> common: Drop uuid.h from common header
> flash: Tidy up coding style for flash functions
> common: Drop flash.h from common header
> arm: Don't include common.h in header files
> common: Drop net.h from common header
> part: Drop disk_partition_t typedef
> common: Drop part.h from common header
> bootstage: Use BOOTSTAGE instead of BOOTSTATE
> common: Drop bootstage.h from common header
> common: Drop image.h from common header
> common: Drop init.h from common header
> command: Remove the cmd_tbl_t typedef
> Fix some checkpatch warnings in calls to debug()
> common: Drop log.h from common header
> common: Drop asm/ptrace.h from common header
> common: Drop asm_offsets.h from common header
> common: Drop linux/bug.h from common header
> common: Drop linux/stringify.h from common header
> Fix some checkpatch warnings in calls to udelay()
> common: Drop linux/delay.h from common header
> Use __ASSEMBLY__ as the assembly macros
> common: Drop linux/bitops.h from common header
I rebased up to patch 13 before things started getting really hairy.
Can you please rebase and resend the series? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200508/ad531ad8/attachment.sig>
next prev parent reply other threads:[~2020-05-08 18:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 20:14 [PATCH v2 00/22] common: Further reduce the size of common.h Simon Glass
2020-04-09 20:14 ` [PATCH v2 01/22] common: Drop uuid.h from common header Simon Glass
2020-04-09 20:14 ` [PATCH v2 02/22] flash: Tidy up coding style for flash functions Simon Glass
2020-04-09 20:14 ` [PATCH v2 03/22] common: Drop flash.h from common header Simon Glass
2020-04-09 20:14 ` [PATCH v2 04/22] arm: Don't include common.h in header files Simon Glass
2020-04-09 20:14 ` [PATCH v2 05/22] common: Drop net.h from common header Simon Glass
2020-04-09 20:14 ` [PATCH v2 06/22] part: Drop disk_partition_t typedef Simon Glass
2020-04-09 20:14 ` [PATCH v2 07/22] common: Drop part.h from common header Simon Glass
2020-04-09 20:14 ` [PATCH v2 08/22] bootstage: Use BOOTSTAGE instead of BOOTSTATE Simon Glass
2020-04-09 20:14 ` [PATCH v2 09/22] common: Drop bootstage.h from common header Simon Glass
2020-04-09 20:14 ` [PATCH v2 10/22] common: Drop image.h " Simon Glass
2020-04-09 20:14 ` [PATCH v2 11/22] common: Drop init.h " Simon Glass
2020-04-09 20:14 ` [PATCH v2 12/22] command: Remove the cmd_tbl_t typedef Simon Glass
2020-04-09 20:14 ` [PATCH v2 13/22] Fix some checkpatch warnings in calls to debug() Simon Glass
2020-04-09 20:14 ` [PATCH v2 14/22] common: Drop log.h from common header Simon Glass
2020-04-09 20:14 ` [PATCH v2 15/22] common: Drop asm/ptrace.h " Simon Glass
2020-04-09 20:15 ` [PATCH v2 16/22] common: Drop asm_offsets.h " Simon Glass
2020-04-09 20:15 ` [PATCH v2 17/22] common: Drop linux/bug.h " Simon Glass
2020-04-09 20:15 ` [PATCH v2 18/22] common: Drop linux/stringify.h " Simon Glass
2020-04-09 20:15 ` [PATCH v2 19/22] Fix some checkpatch warnings in calls to udelay() Simon Glass
2020-04-09 20:15 ` [PATCH v2 20/22] common: Drop linux/delay.h from common header Simon Glass
2020-04-09 20:15 ` [PATCH v2 21/22] Use __ASSEMBLY__ as the assembly macros Simon Glass
2020-04-13 17:09 ` Masahiro Yamada
2020-04-14 14:41 ` Simon Glass
2020-04-14 15:33 ` Masahiro Yamada
2020-04-14 20:38 ` Simon Goldschmidt
2020-04-14 21:04 ` Tom Rini
2020-04-15 4:48 ` Simon Goldschmidt
2020-04-09 20:15 ` [PATCH v2 22/22] common: Drop linux/bitops.h from common header Simon Glass
2020-05-08 18:36 ` Tom Rini [this message]
2020-05-10 15:07 ` [PATCH v2 00/22] common: Further reduce the size of common.h Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508183659.GP12564@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox