From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] tools: ftdgrep: use /* fallthrough */ as needed
Date: Mon, 11 May 2020 14:40:45 -0400 [thread overview]
Message-ID: <20200511184045.GP12564@bill-the-cat> (raw)
In-Reply-To: <CAK7LNAQ6TDt5314aNo4p1ptAjggtEvaDz0ZFndEZ=OkVP_ec4A@mail.gmail.com>
On Sun, May 10, 2020 at 10:12:07PM +0900, Masahiro Yamada wrote:
> On Sun, May 10, 2020 at 12:12 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > GCC recognizes /* fallthrough */ if -Wimplicit-fallthrough=3 is enabled.
>
> FYI.
>
> Linux decided to not use /* fallthrough */ any more
> because Clang does not recognize it.
>
> __attribute__((__fallthrough__)) is supported
> by both Clang and recent GCC.
>
>
> Linux is now doing treewide conversion
> from /* fallthrough */ to 'fallthrough;'.
>
> See include/linux/compiler_attributes.h in Linux.
>
> I do not know if U-Boot wants to align with it.
> (up to Tom ?)
A re-sync on the compiler headers again and making use of this sounds
like a good idea, yes.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200511/a0877143/attachment-0001.sig>
next prev parent reply other threads:[~2020-05-11 18:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 15:12 [PATCH 1/1] tools: ftdgrep: use /* fallthrough */ as needed Heinrich Schuchardt
2020-05-10 13:12 ` Masahiro Yamada
2020-05-11 18:40 ` Tom Rini [this message]
2020-05-11 19:08 ` Heinrich Schuchardt
2020-05-13 3:04 ` Tom Rini
2020-05-13 14:42 ` Tom Rini
2020-05-13 16:05 ` Masahiro Yamada
2020-05-13 16:13 ` Tom Rini
2020-05-13 17:27 ` Masahiro Yamada
2020-05-13 18:41 ` Tom Rini
2020-05-13 21:52 ` Tom Rini
2020-05-15 20:54 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511184045.GP12564@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox