public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: LABBE Corentin <clabbe@baylibre.com>
To: u-boot@lists.denx.de
Subject: [PATCH] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY
Date: Tue, 12 May 2020 13:34:32 +0200	[thread overview]
Message-ID: <20200512113432.GA28162@Red> (raw)
In-Reply-To: <ce3ede41-4dc6-db17-cf1c-ce6116ce3835@suse.com>

On Tue, May 12, 2020 at 12:17:25PM +0200, Matthias Brugger wrote:
> Hi Corentin,
> 
> On 09/05/2020 01:25, Matthias Brugger wrote:
> > On 09/05/2020 01:18, Matthias Brugger wrote:
> >> Hi Corentin,
> >>
> >> On 24/04/2020 14:51, LABBE Corentin wrote:
> >>> On Tue, Mar 31, 2020 at 12:26:35PM +0000, Corentin Labbe wrote:
> >>>> As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/
> >>>> the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
> >>>> Without it, booting with an initrd fail.
> >>>>
> >>>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> >>>> ---
> >>>>  configs/rpi_4_defconfig | 2 +-
> >>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig
> >>>> index 6d148dab07..8540b3c927 100644
> >>>> --- a/configs/rpi_4_defconfig
> >>>> +++ b/configs/rpi_4_defconfig
> >>>> @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
> >>>>  CONFIG_NR_DRAM_BANKS=2
> >>>>  CONFIG_DISTRO_DEFAULTS=y
> >>>>  CONFIG_OF_BOARD_SETUP=y
> >>>> -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
> >>>> +CONFIG_ARCH_FIXUP_FDT_MEMORY=y
> >>>>  CONFIG_MISC_INIT_R=y
> >>>>  # CONFIG_DISPLAY_CPUINFO is not set
> >>>>  # CONFIG_DISPLAY_BOARDINFO is not set
> >>>> -- 
> >>>
> >>
> >> Patch looks good, but is there any reason why you don't enable it for
> >> rpi_4_32b_defconfig and rpi_arm64_defconfig?
> >>
> > 
> > And please add me to the recipients list, otherwise this patches most probably
> > get lost.
> > 
> 
> Are you planning to send a new version of the patch which enables the option for
> all configs?
> 

Yes, I will.
But note that I didnt tested rpi_4_32b_defconfig.
And I am currently unable to test it.
If you want it to be tested, could you apply this patch as is, and I will submit the rpi_4_32b_defconfig later.

Regards

  reply	other threads:[~2020-05-12 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 12:26 [PATCH] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY Corentin Labbe
2020-04-24 12:51 ` LABBE Corentin
2020-05-08 23:18   ` Matthias Brugger
2020-05-08 23:25     ` Matthias Brugger
2020-05-12 10:17       ` Matthias Brugger
2020-05-12 11:34         ` LABBE Corentin [this message]
2020-05-12 11:38           ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512113432.GA28162@Red \
    --to=clabbe@baylibre.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox