From: LABBE Corentin <clabbe@baylibre.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY
Date: Wed, 13 May 2020 13:45:17 +0200 [thread overview]
Message-ID: <20200513114517.GA21476@Red> (raw)
In-Reply-To: <73932a33-6916-8644-9e9c-f1b25d904fb9@suse.com>
On Wed, May 13, 2020 at 12:38:58PM +0200, Matthias Brugger wrote:
>
>
> On 13/05/2020 10:07, Corentin Labbe wrote:
> > As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/
> > the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
> > Without it, booting with an initrd fail.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > Changes since v1:
> > - added fix for rpi_4_32b_defconfig
> >
> > configs/rpi_4_32b_defconfig | 2 +-
> > configs/rpi_4_defconfig | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
>
> Any reason why you don't added rpi_arm64_defconfig?
>
I didnt see rpi4 in its name so out of context of my changes.
I believe it is a common defconfig for all rpis, in that case touching it need more testing.
So I propose to apply the change for rpi4 which are tested now.
And later I could try to test rpi_arm64_defconfig on rpi4 AND other rpis..
>
> > diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig
> > index 8d262d89b4..f2a975891c 100644
> > --- a/configs/rpi_4_32b_defconfig
> > +++ b/configs/rpi_4_32b_defconfig
> > @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
> > CONFIG_NR_DRAM_BANKS=2
> > CONFIG_DISTRO_DEFAULTS=y
> > CONFIG_OF_BOARD_SETUP=y
> > -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
> > +CONFIG_ARCH_FIXUP_FDT_MEMORY=y
> > CONFIG_MISC_INIT_R=y
> > # CONFIG_DISPLAY_CPUINFO is not set
> > # CONFIG_DISPLAY_BOARDINFO is not set
> > diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig
> > index 2a0cea4222..f1c8f5ef7d 100644
> > --- a/configs/rpi_4_defconfig
> > +++ b/configs/rpi_4_defconfig
> > @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
> > CONFIG_NR_DRAM_BANKS=2
> > CONFIG_DISTRO_DEFAULTS=y
> > CONFIG_OF_BOARD_SETUP=y
> > -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
> > +CONFIG_ARCH_FIXUP_FDT_MEMORY=y
> > CONFIG_MISC_INIT_R=y
> > # CONFIG_DISPLAY_CPUINFO is not set
> > # CONFIG_DISPLAY_BOARDINFO is not set
> >
next prev parent reply other threads:[~2020-05-13 11:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200513080753epcas1p1529866fe57ea238049d69fdc40e4b46a@epcas1p1.samsung.com>
2020-05-13 8:07 ` [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY Corentin Labbe
2020-05-13 10:38 ` Matthias Brugger
2020-05-13 11:45 ` LABBE Corentin [this message]
2020-05-15 9:26 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513114517.GA21476@Red \
--to=clabbe@baylibre.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox