From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/5] mtd: spi: Call sst_write in _write ops
Date: Thu, 14 May 2020 17:41:41 +0530 [thread overview]
Message-ID: <20200514121145.28737-2-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20200514121145.28737-1-jagan@amarulasolutions.com>
Currently spi-nor code is assigning _write ops for SST
and other flashes separately.?
Just call the sst_write from generic write ops and return
if SST flash found, this way it avoids the confusion of
multiple write ops assignment during the scan and makes
it more feasible for code readability.
No functionality changes.
Cc: Simon Glass <sjg@chromium.org>
Cc: Vignesh R <vigneshr@ti.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
drivers/mtd/spi/spi-nor-core.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c
index 3d4361493e..984cece0b0 100644
--- a/drivers/mtd/spi/spi-nor-core.c
+++ b/drivers/mtd/spi/spi-nor-core.c
@@ -1233,6 +1233,12 @@ static int spi_nor_write(struct mtd_info *mtd, loff_t to, size_t len,
size_t page_offset, page_remain, i;
ssize_t ret;
+#ifdef CONFIG_SPI_FLASH_SST
+ /* sst nor chips use AAI word program */
+ if (nor->info->flags & SST_WRITE)
+ return sst_write(mtd, to, len, retlen, buf);
+#endif
+
dev_dbg(nor->dev, "to 0x%08x, len %zd\n", (u32)to, len);
if (!len)
@@ -2528,6 +2534,7 @@ int spi_nor_scan(struct spi_nor *nor)
mtd->size = params.size;
mtd->_erase = spi_nor_erase;
mtd->_read = spi_nor_read;
+ mtd->_write = spi_nor_write;
#if defined(CONFIG_SPI_FLASH_STMICRO) || defined(CONFIG_SPI_FLASH_SST)
/* NOR protection support for STmicro/Micron chips and similar */
@@ -2551,13 +2558,7 @@ int spi_nor_scan(struct spi_nor *nor)
nor->flash_unlock = sst26_unlock;
nor->flash_is_locked = sst26_is_locked;
}
-
- /* sst nor chips use AAI word program */
- if (info->flags & SST_WRITE)
- mtd->_write = sst_write;
- else
#endif
- mtd->_write = spi_nor_write;
if (info->flags & USE_FSR)
nor->flags |= SNOR_F_USE_FSR;
--
2.20.1
next prev parent reply other threads:[~2020-05-14 12:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 12:11 [PATCH 0/5] sf: Cleanup Jagan Teki
2020-05-14 12:11 ` Jagan Teki [this message]
2020-05-19 19:15 ` [PATCH 1/5] mtd: spi: Call sst_write in _write ops Jagan Teki
2020-05-14 12:11 ` [PATCH 2/5] cmd: sf Drop reassignment of new into flash Jagan Teki
2020-05-19 19:25 ` Jagan Teki
2020-05-14 12:11 ` [PATCH 3/5] env: sf: Preserve and free the previous flash Jagan Teki
2020-05-15 7:24 ` Pratyush Yadav
2020-05-15 7:44 ` Jagan Teki
2020-05-15 8:49 ` Pratyush Yadav
2020-05-18 12:06 ` Jagan Teki
2020-05-18 15:41 ` Pratyush Yadav
2020-05-14 12:11 ` [PATCH 4/5] mtd: sf: Drop plat from sf_probe Jagan Teki
2020-05-15 7:17 ` Pratyush Yadav
2020-05-19 19:32 ` Jagan Teki
2020-05-14 12:11 ` [PATCH 5/5] mtd: spi: Use IS_ENABLED to prevent ifdef Jagan Teki
2020-05-14 16:31 ` Daniel Schwierzeck
2020-05-15 4:27 ` Stefan Roese
2020-05-15 7:22 ` Rasmus Villemoes
2020-05-15 7:33 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514121145.28737-2-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox