From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 15 May 2020 14:47:21 -0400 Subject: [PATCH 1/3] log: Allow LOG_DEBUG to always enable log output In-Reply-To: <20200506140357.32050-1-sjg@chromium.org> References: <20200506140357.32050-1-sjg@chromium.org> Message-ID: <20200515184721.GA6647@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, May 06, 2020 at 08:03:55AM -0600, Simon Glass wrote: > At present if CONFIG_LOG enabled, putting LOG_DEBUG at the top of a file > (before log.h inclusion) causes _log() to be executed for every log() > call, regardless of the build- or run-time logging level. > > However there is no guarantee that the log record will actually be > displayed. If the current log level is lower than LOGL_DEBUG then it will > not be. > > Add a way to signal that the log record should always be displayed and > update log_passes_filters() to handle this. > > Signed-off-by: Simon Glass > --- > > common/log.c | 6 +++++- > doc/README.log | 7 ++----- > include/log.h | 16 ++++++++++++---- > 3 files changed, 19 insertions(+), 10 deletions(-) Two levels of problems with (I believe) this patch: https://gitlab.denx.de/u-boot/u-boot/-/jobs/94674 fails a unit test now around logging. https://gitlab.denx.de/u-boot/u-boot/-/jobs/94671 shows a ton of new warnings with clang. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: