* [PATCH 2/6] board_r: env: Use IS_ENABLED() instead of #ifdefs
2020-05-06 17:38 [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig Ovidiu Panait
@ 2020-05-06 17:38 ` Ovidiu Panait
2020-05-16 1:45 ` Tom Rini
2020-05-06 17:38 ` [PATCH 3/6] board_r: Introduce CONFIG_PCI_INIT_R Kconfig option Ovidiu Panait
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Ovidiu Panait @ 2020-05-06 17:38 UTC (permalink / raw)
To: u-boot
Use IS_ENABLED() instead of #ifdef in should_load_env and initr_env
functions.
No functional change intended.
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
common/board_r.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index d9015cd057..f6770f2300 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -464,13 +464,14 @@ static int initr_mmc(void)
*/
static int should_load_env(void)
{
-#ifdef CONFIG_OF_CONTROL
- return fdtdec_get_config_int(gd->fdt_blob, "load-environment", 1);
-#elif defined CONFIG_DELAY_ENVIRONMENT
- return 0;
-#else
+ if (IS_ENABLED(CONFIG_OF_CONTROL))
+ return fdtdec_get_config_int(gd->fdt_blob,
+ "load-environment", 1);
+
+ if (IS_ENABLED(CONFIG_DELAY_ENVIRONMENT))
+ return 0;
+
return 1;
-#endif
}
static int initr_env(void)
@@ -480,10 +481,10 @@ static int initr_env(void)
env_relocate();
else
env_set_default(NULL, 0);
-#ifdef CONFIG_OF_CONTROL
- env_set_hex("fdtcontroladdr",
- (unsigned long)map_to_sysmem(gd->fdt_blob));
-#endif
+
+ if (IS_ENABLED(CONFIG_OF_CONTROL))
+ env_set_hex("fdtcontroladdr",
+ (unsigned long)map_to_sysmem(gd->fdt_blob));
/* Initialize from environment */
image_load_addr = env_get_ulong("loadaddr", 16, image_load_addr);
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/6] board_r: Introduce CONFIG_PCI_INIT_R Kconfig option
2020-05-06 17:38 [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig Ovidiu Panait
2020-05-06 17:38 ` [PATCH 2/6] board_r: env: Use IS_ENABLED() instead of #ifdefs Ovidiu Panait
@ 2020-05-06 17:38 ` Ovidiu Panait
2020-05-16 1:45 ` Tom Rini
2020-05-06 17:38 ` [PATCH 4/6] qemu_arm64_defconfig: Enable CONFIG_PCI_INIT_R Ovidiu Panait
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Ovidiu Panait @ 2020-05-06 17:38 UTC (permalink / raw)
To: u-boot
With CONFIG_DM_PCI enabled, PCI buses are not enumerated at boot, as they
are without that config option enabled. However, there are cases such as DM
PCI-based Ethernet devices that need the PCI bus enumerated so that they
can be discovered by their drivers.
Currently, to solve this, some boards enumerate the pci bus using
"pci enum" preboot command, while others do it manually in board files
(in board_init/board_late_init/etc. functions).
In order to possibly make the pci enumeration process uniform across all
boards, introduce CONFIG_PCI_INIT_R Kconfig option.
This change also preserves the current behavior in the !DM_PCI case
(pci_init is run unconditionally at boot).
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
common/Kconfig | 10 ++++++++++
common/board_r.c | 5 ++---
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/common/Kconfig b/common/Kconfig
index 30cba15948..2d86dd7e63 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -932,6 +932,16 @@ config LAST_STAGE_INIT
U-Boot calls last_stage_init() before the command-line interpreter is
started.
+config PCI_INIT_R
+ bool "Enumerate PCI buses during init"
+ depends on PCI
+ default y if !DM_PCI
+ help
+ With this option U-Boot will call pci_init() soon after relocation,
+ which will enumerate PCI buses. This is needed, for instance, in the
+ case of DM PCI-based Ethernet devices, which will not be detected
+ without having the enumeration performed earlier.
+
endmenu
menu "Security support"
diff --git a/common/board_r.c b/common/board_r.c
index f6770f2300..96034b874e 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -232,9 +232,8 @@ static int initr_unlock_ram_in_cache(void)
#ifdef CONFIG_PCI
static int initr_pci(void)
{
-#ifndef CONFIG_DM_PCI
- pci_init();
-#endif
+ if (IS_ENABLED(CONFIG_PCI_INIT_R))
+ pci_init();
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/6] board_r: Introduce CONFIG_PCI_INIT_R Kconfig option
2020-05-06 17:38 ` [PATCH 3/6] board_r: Introduce CONFIG_PCI_INIT_R Kconfig option Ovidiu Panait
@ 2020-05-16 1:45 ` Tom Rini
0 siblings, 0 replies; 12+ messages in thread
From: Tom Rini @ 2020-05-16 1:45 UTC (permalink / raw)
To: u-boot
On Wed, May 06, 2020 at 08:38:44PM +0300, Ovidiu Panait wrote:
> With CONFIG_DM_PCI enabled, PCI buses are not enumerated at boot, as they
> are without that config option enabled. However, there are cases such as DM
> PCI-based Ethernet devices that need the PCI bus enumerated so that they
> can be discovered by their drivers.
>
> Currently, to solve this, some boards enumerate the pci bus using
> "pci enum" preboot command, while others do it manually in board files
> (in board_init/board_late_init/etc. functions).
>
> In order to possibly make the pci enumeration process uniform across all
> boards, introduce CONFIG_PCI_INIT_R Kconfig option.
>
> This change also preserves the current behavior in the !DM_PCI case
> (pci_init is run unconditionally at boot).
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200515/4957dcb4/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/6] qemu_arm64_defconfig: Enable CONFIG_PCI_INIT_R
2020-05-06 17:38 [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig Ovidiu Panait
2020-05-06 17:38 ` [PATCH 2/6] board_r: env: Use IS_ENABLED() instead of #ifdefs Ovidiu Panait
2020-05-06 17:38 ` [PATCH 3/6] board_r: Introduce CONFIG_PCI_INIT_R Kconfig option Ovidiu Panait
@ 2020-05-06 17:38 ` Ovidiu Panait
2020-05-16 1:45 ` Tom Rini
2020-05-06 17:38 ` [PATCH 5/6] qemu_arm_defconfig: " Ovidiu Panait
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Ovidiu Panait @ 2020-05-06 17:38 UTC (permalink / raw)
To: u-boot
Replace the "pci enum" preboot sequence with CONFIG_PCI_INIT_R=y.
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
configs/qemu_arm64_defconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
index 80e0ad55e0..53c653df21 100644
--- a/configs/qemu_arm64_defconfig
+++ b/configs/qemu_arm64_defconfig
@@ -10,10 +10,9 @@ CONFIG_FIT_SIGNATURE=y
CONFIG_FIT_VERBOSE=y
CONFIG_FIT_BEST_MATCH=y
CONFIG_LEGACY_IMAGE_FORMAT=y
-CONFIG_USE_PREBOOT=y
-CONFIG_PREBOOT="pci enum"
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_PCI_INIT_R=y
CONFIG_CMD_BOOTEFI_SELFTEST=y
CONFIG_CMD_NVEDIT_EFI=y
CONFIG_CMD_PCI=y
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 5/6] qemu_arm_defconfig: Enable CONFIG_PCI_INIT_R
2020-05-06 17:38 [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig Ovidiu Panait
` (2 preceding siblings ...)
2020-05-06 17:38 ` [PATCH 4/6] qemu_arm64_defconfig: Enable CONFIG_PCI_INIT_R Ovidiu Panait
@ 2020-05-06 17:38 ` Ovidiu Panait
2020-05-16 1:46 ` Tom Rini
2020-05-06 17:38 ` [PATCH 6/6] qemu-x86*_defconfig: " Ovidiu Panait
2020-05-16 1:45 ` [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig Tom Rini
5 siblings, 1 reply; 12+ messages in thread
From: Ovidiu Panait @ 2020-05-06 17:38 UTC (permalink / raw)
To: u-boot
Replace the "pci enum" preboot sequence with CONFIG_PCI_INIT_R=y.
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
configs/qemu_arm_defconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
index f807dfc10e..a8473988bd 100644
--- a/configs/qemu_arm_defconfig
+++ b/configs/qemu_arm_defconfig
@@ -12,10 +12,9 @@ CONFIG_FIT_SIGNATURE=y
CONFIG_FIT_VERBOSE=y
CONFIG_FIT_BEST_MATCH=y
CONFIG_LEGACY_IMAGE_FORMAT=y
-CONFIG_USE_PREBOOT=y
-CONFIG_PREBOOT="pci enum"
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_PCI_INIT_R=y
CONFIG_CMD_BOOTEFI_SELFTEST=y
CONFIG_CMD_NVEDIT_EFI=y
CONFIG_CMD_PCI=y
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 6/6] qemu-x86*_defconfig: Enable CONFIG_PCI_INIT_R
2020-05-06 17:38 [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig Ovidiu Panait
` (3 preceding siblings ...)
2020-05-06 17:38 ` [PATCH 5/6] qemu_arm_defconfig: " Ovidiu Panait
@ 2020-05-06 17:38 ` Ovidiu Panait
2020-05-16 1:46 ` Tom Rini
2020-05-16 1:45 ` [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig Tom Rini
5 siblings, 1 reply; 12+ messages in thread
From: Ovidiu Panait @ 2020-05-06 17:38 UTC (permalink / raw)
To: u-boot
Enable CONFIG_PCI_INIT_R for qemux86 and qemux86-64 pci enumeration during
boot in order to eliminate the custom preboot commands in
include/configs/qemu-x86.h.
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
configs/qemu-x86_64_defconfig | 1 +
configs/qemu-x86_defconfig | 1 +
include/configs/qemu-x86.h | 2 --
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 0cb123eb4a..6f722c1d23 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -34,6 +34,7 @@ CONFIG_SPL_NET_SUPPORT=y
CONFIG_SPL_PCI=y
CONFIG_SPL_PCH_SUPPORT=y
CONFIG_SPL_RTC_SUPPORT=y
+CONFIG_PCI_INIT_R=y
CONFIG_CMD_CPU=y
CONFIG_CMD_BOOTEFI_SELFTEST=y
CONFIG_CMD_NVEDIT_EFI=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index a562f213e1..565f232b4f 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -18,6 +18,7 @@ CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro"
CONFIG_SYS_CONSOLE_INFO_QUIET=y
CONFIG_DISPLAY_BOARDINFO_LATE=y
CONFIG_LAST_STAGE_INIT=y
+CONFIG_PCI_INIT_R=y
CONFIG_CMD_CPU=y
CONFIG_CMD_BOOTEFI_SELFTEST=y
CONFIG_CMD_NVEDIT_EFI=y
diff --git a/include/configs/qemu-x86.h b/include/configs/qemu-x86.h
index 49e307b430..52c33600b3 100644
--- a/include/configs/qemu-x86.h
+++ b/include/configs/qemu-x86.h
@@ -22,8 +22,6 @@
#include <config_distro_bootcmd.h>
#include <configs/x86-common.h>
-#define CONFIG_PREBOOT "pci enum"
-
#define CONFIG_SYS_MONITOR_LEN (1 << 20)
#define CONFIG_STD_DEVICES_SETTINGS "stdin=serial,i8042-kbd\0" \
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig
2020-05-06 17:38 [PATCH 1/6] env: Convert CONFIG_DELAY_ENVIRONMENT to Kconfig Ovidiu Panait
` (4 preceding siblings ...)
2020-05-06 17:38 ` [PATCH 6/6] qemu-x86*_defconfig: " Ovidiu Panait
@ 2020-05-16 1:45 ` Tom Rini
5 siblings, 0 replies; 12+ messages in thread
From: Tom Rini @ 2020-05-16 1:45 UTC (permalink / raw)
To: u-boot
On Wed, May 06, 2020 at 08:38:42PM +0300, Ovidiu Panait wrote:
> This converts ad-hoc CONFIG_DELAY_ENVIRONMENT to Kconfig.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200515/bc159238/attachment-0001.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread