[PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

Peng Fan
2020-05-19T10:05:21Z

> Subject: Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert
> property value
>
> Hi Peng,
>
> On Sun, 17 May 2020 16:53:17 +0200
> Anatolij Gustschin agust at denx.de wrote:
> ...
> > Will try to bisect later.
>
> bisecting leads to:
> # first bad commit: [3ee6ea443eb466399ab325a58b377326ac5c57b5]
> cpu: imx_cpu: Print the CPU temperature for iMX8QM A72

Would this help?

diff --git a/drivers/cpu/imx8_cpu.c b/drivers/cpu/imx8_cpu.c
index 95c14c98d8..6c949ccbd4 100644
--- a/drivers/cpu/imx8_cpu.c
+++ b/drivers/cpu/imx8_cpu.c
@@ -68,10 +68,13 @@ static int cpu_imx_get_temp(struct cpu_imx_platdata *plat)
struct udevice *thermal_dev;
int cpu_tmp, ret;

- if (!strcmp(plat->name, "A72"))
- ret = uclass_get_device(UCLASS_THERMAL, 1, &thermal_dev);
- else
- ret = uclass_get_device(UCLASS_THERMAL, 0, &thermal_dev);
+ if (!strcmp(plat->name, "A72")) {
+ ret = uclass_get_device_by_name(UCLASS_THERMAL, "cpu-thermal1",
+ &thermal_dev);
+ } else {
+ ret = uclass_get_device_by_name(UCLASS_THERMAL, "cpu-thermal0",
+ &thermal_dev);
+ }

if (!ret) {
ret = thermal_get_temp(thermal_dev, &cpu_tmp);

Thanks,
Peng.
>
> --
> Anatolij