From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Date: Thu, 21 May 2020 09:13:32 +0900 Subject: [PATCH] efi_loader: Remove unnecessary debug In-Reply-To: References: <20200519101335.5030-1-pragnesh.patel@sifive.com> Message-ID: <20200521001332.GA21353@laputa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, May 19, 2020 at 12:24:27PM +0200, Heinrich Schuchardt wrote: > On 19.05.20 12:13, Pragnesh Patel wrote: > > Remove unnecessary debug() from efi_set_variable_common(). > > native_name is NULL, so there is no meaning to print it. > > > > Signed-off-by: Pragnesh Patel > > Reviewed-by: Heinrich Schuchardt Nak > > lib/efi_loader/efi_variable.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c > > index 10892684d1..9698efbc5d 100644 > > --- a/lib/efi_loader/efi_variable.c > > +++ b/lib/efi_loader/efi_variable.c > > @@ -883,8 +883,6 @@ static efi_status_t efi_set_variable_common(u16 *variable_name, > > u32 attr; > > efi_status_t ret = EFI_SUCCESS; > > > > - debug("%s: set '%s'\n", __func__, native_name); Instead, debug("%s: set '%ls'\n", __func__, variable_name); It would be helpful for tracing activities. This function can be used outside of this file, particularly, to handle READ_ONLY variables there. -Takahiro Akashi > > - > > if (!variable_name || !*variable_name || !vendor || > > ((attributes & EFI_VARIABLE_RUNTIME_ACCESS) && > > !(attributes & EFI_VARIABLE_BOOTSERVICE_ACCESS))) { > > >