[PATCH] mmc: fsl_esdhc: Fix SDR104 and HS200 support

[PATCH] mmc: fsl_esdhc: Fix SDR104 and HS200 support

[Marek Vasut]

The 3V3/1V8 switching could never have worked on any of the iMXes
ever since 51313b49f2 ("mmc: fsl_esdhc: support SDR104 and HS200"),
because that commit uses priv->vqmmc_dev when switching voltages on
mode switch, while local vqmmc_dev in probe to store the regulator
pointer. Those are two different variables with the same name. So
the priv->vqmmc_dev was always NULL and thus voltage switch between
modes never really suceeded.

Fix this by assigning priv->vqmmc_dev with value of the vqmmc_dev
in probe.

Fixes: 51313b49f2 ("mmc: fsl_esdhc: support SDR104 and HS200")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
---
 drivers/mmc/fsl_esdhc_imx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c
index 588d6a9d76..f3101a061a 100644
--- a/drivers/mmc/fsl_esdhc_imx.c
+++ b/drivers/mmc/fsl_esdhc_imx.c
@@ -1455,6 +1455,7 @@ static int fsl_esdhc_probe(struct udevice *dev)
 	if (ret) {
 		dev_dbg(dev, "no vqmmc-supply\n");
 	} else {
+		priv->vqmmc_dev = vqmmc_dev;
 		ret = regulator_set_enable(vqmmc_dev, true);
 		if (ret) {
 			dev_err(dev, "fail to enable vqmmc-supply\n");
-- 
2.25.1

[PATCH] mmc: fsl_esdhc: Fix SDR104 and HS200 support

[Jaehoon Chung]

On 5/23/20 1:19 AM, Marek Vasut wrote:
> The 3V3/1V8 switching could never have worked on any of the iMXes
> ever since 51313b49f2 ("mmc: fsl_esdhc: support SDR104 and HS200"),
> because that commit uses priv->vqmmc_dev when switching voltages on
> mode switch, while local vqmmc_dev in probe to store the regulator
> pointer. Those are two different variables with the same name. So
> the priv->vqmmc_dev was always NULL and thus voltage switch between
> modes never really suceeded.
> 
> Fix this by assigning priv->vqmmc_dev with value of the vqmmc_dev
> in probe.
> 
> Fixes: 51313b49f2 ("mmc: fsl_esdhc: support SDR104 and HS200")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

> ---
>  drivers/mmc/fsl_esdhc_imx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c
> index 588d6a9d76..f3101a061a 100644
> --- a/drivers/mmc/fsl_esdhc_imx.c
> +++ b/drivers/mmc/fsl_esdhc_imx.c
> @@ -1455,6 +1455,7 @@ static int fsl_esdhc_probe(struct udevice *dev)
>  	if (ret) {
>  		dev_dbg(dev, "no vqmmc-supply\n");
>  	} else {
> +		priv->vqmmc_dev = vqmmc_dev;
>  		ret = regulator_set_enable(vqmmc_dev, true);
>  		if (ret) {
>  			dev_err(dev, "fail to enable vqmmc-supply\n");
>