From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 0/6] checkpatch.pl: Add features to help improve U-Boot code
Date: Sun, 24 May 2020 14:23:35 -0400 [thread overview]
Message-ID: <20200524182335.GI26741@bill-the-cat> (raw)
In-Reply-To: <20200522223240.187032-1-sjg@chromium.org>
On Fri, May 22, 2020 at 04:32:34PM -0600, Simon Glass wrote:
> U-Boot mostly follows linux for coding style, but it has some of its own
> features. These come up again and again in code review. We should try to
> reduce the load of reviewers.
>
> This series adds a little U-Boot function to the checkpatch script and an
> option to enable it. Hopefully it is easy enough to maintain this as the
> script is updated, even if it is not accepted upstream.
>
> Some initial checks are included as examples of what we can do.
>
>
> Simon Glass (6):
> checkpatch.pl: Update to v5.7-rc6
> checkpatch.pl: Add a U-Boot option
> checkpatch.pl: Add a check for tests needed for uclasses
> checkpatch.pl: Warn if the flattree API is used
> checkpatch.pl: Request a test when a new command is added
> checkpatch.pl: Request if() instead #ifdef
>
> .checkpatch.conf | 3 +
> doc/README.commands | 50 +++++++++
> scripts/checkpatch.pl | 252 +++++++++++++++---------------------------
> 3 files changed, 144 insertions(+), 161 deletions(-)
I'm not reviewing the changes as I am not a pearl person but I think
this is a great idea and will help keep us from dropping our changes in
the future too. I'll rebase my CONFIG_CMD_xxx check on top of your
series before applying.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200524/98584393/attachment.sig>
next prev parent reply other threads:[~2020-05-24 18:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 22:32 [PATCH 0/6] checkpatch.pl: Add features to help improve U-Boot code Simon Glass
2020-05-22 22:32 ` [PATCH 1/6] checkpatch.pl: Update to v5.7-rc6 Simon Glass
2020-06-04 23:39 ` Tom Rini
2020-05-22 22:32 ` [PATCH 2/6] checkpatch.pl: Add a U-Boot option Simon Glass
2020-06-04 23:39 ` Tom Rini
2020-05-22 22:32 ` [PATCH 3/6] checkpatch.pl: Add a check for tests needed for uclasses Simon Glass
2020-06-04 23:39 ` Tom Rini
2020-05-22 22:32 ` [PATCH 4/6] checkpatch.pl: Warn if the flattree API is used Simon Glass
2020-06-04 23:39 ` Tom Rini
2020-05-22 22:32 ` [PATCH 5/6] checkpatch.pl: Request a test when a new command is added Simon Glass
2020-06-04 23:39 ` Tom Rini
2020-05-22 22:32 ` [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef Simon Glass
2020-06-04 23:39 ` Tom Rini
2020-06-15 2:58 ` AKASHI Takahiro
2020-06-15 3:58 ` Simon Glass
2020-06-15 14:34 ` Tom Rini
2020-06-16 0:34 ` AKASHI Takahiro
2020-06-16 1:21 ` Tom Rini
2020-06-16 2:15 ` Simon Glass
2020-05-24 18:23 ` Tom Rini [this message]
2020-05-26 18:29 ` [PATCHv2] checkpatch.pl: Add check for defining CONFIG_CMD_xxx via config files Tom Rini
2020-06-04 23:39 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524182335.GI26741@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox